Re: [2/2 v2] riched20: Implement alignment styles support.

[Huw Davies]

On Fri, Nov 06, 2015 at 10:44:57AM +0800, Jactry Zeng wrote:
> --- a/dlls/riched20/editor.h
> +++ b/dlls/riched20/editor.h
> @@ -213,7 +213,7 @@ void ME_DumpParaStyleToBuf(const PARAFORMAT2 *pFmt, char buf[2048]) DECLSPEC_HID
>  BOOL ME_SetSelectionParaFormat(ME_TextEditor *editor, const PARAFORMAT2 *pFmt) DECLSPEC_HIDDEN;
>  void ME_GetSelectionParaFormat(ME_TextEditor *editor, PARAFORMAT2 *pFmt) DECLSPEC_HIDDEN;
>  void ME_MarkAllForWrapping(ME_TextEditor *editor) DECLSPEC_HIDDEN;
> -void ME_SetDefaultParaFormat(PARAFORMAT2 *pFmt) DECLSPEC_HIDDEN;
> +void ME_SetDefaultParaFormat(DWORD alignStyle, PARAFORMAT2 *pFmt) DECLSPEC_HIDDEN;

Why did you change this?  Your last patch had ME_TextEditor*
as the first parameter, which was much better.
> --- a/dlls/riched20/tests/editor.c
> +++ b/dlls/riched20/tests/editor.c
> @@ -7951,6 +7951,77 @@ static void test_EM_SETFONTSIZE(void)
>      DestroyWindow(richedit);
>  }
> -

^
There's a trailing space here.

Huw.

[2/2 v2] riched20: Implement alignment styles support.

[Jactry Zeng]

Hi,
2015-11-06 16:52 GMT+08:00 Huw Davies :
> Why did you change this?  Your last patch had ME_TextEditor*
> as the first parameter, which was much better.

Because I find we only need alignStyle here, so used editor->alignStyle
instead.
But I don't tend to prefer one of them. :-)
Will send another try.

Thanks.