regression: msvc4.0 install dies sooner now

[Dan Kegel]

I found an unopened copy of msvc++ 4.0 at a garage sale last year for $5,
couldn't resist.  Today I finally tried to install it under Wine.

wine-20020605-2 (rh8):
installer started; when I clicked on 'Install Visual C++',
it put up a 'Installing... please wait' dialog, then failed with a
'Can't read version info from C:\windows\kernel386.drv' message
(more or less), then hung.

wine-20021125 (from source):
installer started; when I clicked on 'Install Visual C++', it hung.

Looks like a regression to me.

Logs of --debugmsg +relay are up at
http://www.kegel.com/msvc4setup-wine20020605.log.bz2
http://www.kegel.com/msvc4setup-wine20021125.log.bz2
The latter file is 28MB uncompressed, 512KB compressed.

I'm now building the intermediate releases of wine to
see if I can narrow down when the regression occurred.

- Dan

[Dan Kegel]

Dan Kegel wrote:
> I found an unopened copy of msvc++ 4.0 at a garage sale last year for $5,
> couldn't resist.  Today I finally tried to install it under Wine.

OK, more details.  I switched to testing the simplest
function of msvc's setup program: the exit button.
All I do is click on the exit button.  (Easy, right?)
It works fine in Wine-20020804, but fails in Wine-20020904 and later.

Logs at
http://www.kegel.com/msvc4-setup-wine-20020804.ok.log.bz2
http://www.kegel.com/msvc4-setup-wine-20020904.bad.log.bz2

The interesting part is the 1000 lines after the line containing 'Button';
it looks like in the later wines, the program gets stuck
in a WaitForSingleObject, maybe.  I have to kill Wine to recover.

Next step appears to be for me to download
ftp://ftp.winehq.com/pub/wine/wine-cvsdirs-20020804.tar.gz
and start fetching the cvs tree as of particular days in
August, and figure out exactly which commit caused the regression.
What cvs command do I use to do that (it's not documented on
winehq.com, I think)?  Or is there a better way?

Thanks,
Dan

[Greg Turner]

On Monday 02 December 2002 01:19 am, Dan Kegel wrote:
> Dan Kegel wrote:
> > I found an unopened copy of msvc++ 4.0 at a garage sale last year
> > for $5, couldn't resist.  Today I finally tried to install it under
> > Wine.
>
> OK, more details.  I switched to testing the simplest
> function of msvc's setup program: the exit button.
> All I do is click on the exit button.  (Easy, right?)
> It works fine in Wine-20020804, but fails in Wine-20020904 and later.
>
> Logs at
> http://www.kegel.com/msvc4-setup-wine-20020804.ok.log.bz2
> http://www.kegel.com/msvc4-setup-wine-20020904.bad.log.bz2
>
> The interesting part is the 1000 lines after the line containing
> 'Button'; it looks like in the later wines, the program gets stuck
> in a WaitForSingleObject, maybe.  I have to kill Wine to recover.
>
> Next step appears to be for me to download
> ftp://ftp.winehq.com/pub/wine/wine-cvsdirs-20020804.tar.gz
> and start fetching the cvs tree as of particular days in
> August, and figure out exactly which commit caused the regression.
> What cvs command do I use to do that (it's not documented on
> winehq.com, I think)?  Or is there a better way?
>
> Thanks,
> Dan

cvs is the "right way" although I forget how it's done.  I've used tkcvs 
for this sort of thing.  it's a horrible anachronistic kinda gui but it 
has a really useful graphical view of each file's history in there that 
can be a huge help when tracking down a particular change.  A picture 
is worth 1000 keystrokes sometimes...

[Paul Millar]

On Mon, 2 Dec 2002, Greg Turner wrote:
> cvs is the "right way" although I forget how it's done.

For the record, Gerard's writeup on how to do CVS regression hunting is
available here:

http://cvs.winehq.com/cvsweb/wine/documentation/cvs-regression.sgml

----
Paul Millar

[Dan Kegel]

Paul Millar wrote:
> For the record, Gerard's writeup on how to do CVS regression hunting is
> available here:
>
> http://cvs.winehq.com/cvsweb/wine/documentation/cvs-regression.sgml

Thanks!
I guess
http://www.winehq.org/download/
should link to
http://www.winehq.org/Docs/wine-devel/cvs-regression.shtml
at the end of the section "Getting Wine from CVS", maybe?
- Dan

[Dimitrie O. Paun]

On December 2, 2002 03:04 am, Greg Turner wrote:
> cvs is the "right way" although I forget how it's done.  I've used tkcvs
> for this sort of thing.  it's a horrible anachronistic kinda gui but it
> has a really useful graphical view of each file's history in there that
> can be a huge help when tracking down a particular change.  A picture
> is worth 1000 keystrokes sometimes...

BTW, anyone willing to take wincvs for a spin. Is a very nice CVS frontend,
for those of use addicted to clicking about, and a perfect target for Wine!

http://www.wincvs.org

[Dan Kegel]

Dan Kegel wrote:
> Dan Kegel wrote:
> > I found an unopened copy of msvc++ 4.0 at a garage sale last year for $5,
> > couldn't resist.  Today I finally tried to install it under Wine.
>
> OK, more details.  I switched to testing the simplest
> function of msvc's setup program: the exit button.
> All I do is click on the exit button.  (Easy, right?)
> It works fine in Wine-20020804, but fails in Wine-20020904 and later.

Following http://www.winehq.org/Docs/wine-devel/cvs-regression.shtml
I managed to narrow the problem down to between 2002-08-26 and 2002-08-28.
I'll narrow it down more when I get a chance.

I'm sorely tempted to install http://ccache.samba.org/
or http://distcc.samba.org/ or even http://gecc.sourceforge.net/
as the 25 minutes it takes to do a full rebuild of wine
is a bit of an impediment.  (Though a big, big improvement
from how long it took the first time I tried to build it
back in the days of 90 MHz pentiums...)

- Dan