I don't think winesetup needs big changes; I'm still not sure about what is broken. The attached file updates the registry shipped with winesetuptk to the current winedefault.reg, and also updates the dlls that are created when making a fake windows installation. As I've said, I'm not sure of what is broken, but if what has to go isn't determined by winesetuptk while running (Like the AppDefaults) then it's just a question of removing whatever has to go from the cfg_wine_without_windows.ini and/or cfg_wine_with_windows.ini. If anything else has to be changed, then Vincent should tell Alex what exactly has to change, so Alex can get on with it. This is presumably the quickest way of getting a working winesetuptk again, as he know Tcl/Tk very well. It's not worth wasting too much time on it, as were going to trash it soon, it doesn't matter if it can't tweak all aspects of the config file, it just has to make a working configuration for the user, that will often have to tweak the file by hand anyway until winecfg is ready.
Le lun 13/10/2003 à 13:08, Ivan Leo Murray-Smith a écrit :
I don't think winesetup needs big changes; I'm still not sure about what is broken. The attached file updates the registry shipped with winesetuptk to the current winedefault.reg, and also updates the dlls that are created when making a fake windows installation. As I've said, I'm not sure of what is broken, but if what has to go isn't determined by winesetuptk while running (Like the AppDefaults) then it's just a question of removing whatever has to go from the cfg_wine_without_windows.ini and/or cfg_wine_with_windows.ini. If anything else has to be changed, then Vincent should tell Alex what exactly has to change, so Alex can get on with it. This is presumably the quickest way of getting a working winesetuptk again, as he know Tcl/Tk very well. It's not worth wasting too much time on it, as were going to trash it soon, it doesn't matter if it can't tweak all aspects of the config file, it just has to make a working configuration for the user, that will often have to tweak the file by hand anyway until winecfg is ready.
Hi Ivan,
In addition to the registry and the default C (although for that wineinstall should be preferred, or at least both should give the same set of defaults), there were a couple entries in the template config file which were absent or obsolete. This patch should take care of them.
Alex, I tried to make winesetuptk keep comments after a key (see first chunk of CBase.itcl), but I had some problems making sure all calls to DataAddKey had another arg named aComment. There was at least one call which would make it crash. I can revive my attempt at that, or we can just make winesetuptk eat those comments. Is an empty string {} or "" in TCL? If you work on it, could you also look in how the [spooler] section is read/written, so we don't lose "FILE" in case we edit a file containing it? Thanks.
With both patches applied, the default config and registry look pretty much the same (except for some trivial things like which drive is home, tmp, etc.) to what wineinstall gives us. Which can lead to the question, what's the purpose of it if wineinstall can do it?
Vincent
Vincent Béron wrote:
Alex, I tried to make winesetuptk keep comments after a key (see first chunk of CBase.itcl), but I had some problems making sure all calls to DataAddKey had another arg named aComment. There was at least one call which would make it crash. I can revive my attempt at that, or we can just make winesetuptk eat those comments.
It shouldn't be too hard to preserve them. I'd like the thing to be able to read my config file and write it back with only whitespace changes.
Is an empty string {} or "" in TCL?
Well, the trouble with Tcl is that there are no real data types, so depending on the commands used, the contents of variables and constants can be interpreted different ways. The {}, "", [list ], and undecorated constructions do very different things, but in some simple cases (e.g. null strings or strings containing only a-z,0-9), they give the same results. This results in many people not bothering to learn the difference until they can't get their script to work (e.g. it fails only for certain input data). :) Sorry, but I've spent a lot of time helping people with things like that! That said, I normally use "" to denote anything that I mean to be a literal string, always construct lists using [list ], etc, just so it's obvious what was intended even if I could save a few characters by doing it a different way.
If you work on it, could you also look in how the [spooler] section is read/written, so we don't lose "FILE" in case we edit a file containing it?
Yeah, I just tried running the SourceForge version of it for the fist time, and I noticed the same thing with my WinMM section getting deleted.
With both patches applied, the default config and registry look pretty much the same (except for some trivial things like which drive is home, tmp, etc.) to what wineinstall gives us. Which can lead to the question, what's the purpose of it if wineinstall can do it?
With the SourceForge version, I backed up my settings and let it create a new config file, and it was at least good enough to run some simple apps, and I think that's all people are looking for right now. Now, my computer is Linux-only, so if there are any problems with the detection of Windows partitions, someone else will have to report about them.
Later tonight I'll make those changes and merge these patches from today together and send an update.
BTW I'm starting a new thread for some other discussion...
Alex
-
Alex Pasadyn -
Ivan Leo Murray-Smith -
Vincent Béron