Re: [PATCH] vbscript: Implemented GetLocale(try 2)

[Piotr Caban]

On 03/17/15 09:29, Shuai Meng wrote:
> -#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON        207
> -#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND     208
> -#define DISPID_GLOBAL_VBMSGBOXRIGHT             209
> -#define DISPID_GLOBAL_VBMSGBOXRTLREADING        210
> +#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON        208
> +#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND     209
> +#define DISPID_GLOBAL_VBMSGBOXRIGHT             210
> +#define DISPID_GLOBAL_VBMSGBOXRTLREADING        211
>
> #define DISPID_GLOBAL_CCUR                      100
>   #define DISPID_GLOBAL_CINT                      101
> @@ -210,6 +210,7 @@
>   #define DISPID_GLOBAL_EXECUTE                   204
>   #define DISPID_GLOBAL_EXECUTEGLOBAL             205
>   #define DISPID_GLOBAL_GETREF                    206
> +#define DISPID_GLOBAL_GETLOCALE                 207

This changes are not matching the typelib in native vbscript.dll. It 
looks like GetLocale function is not defined there at all.

[PATCH] vbscript: Implemented GetLocale(try 2)

[Shuai Meng]

2015-03-18 18:35 GMT+08:00 Piotr Caban :
> On 03/17/15 09:29, Shuai Meng wrote:
> > -#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON        207
> > -#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND     208
> > -#define DISPID_GLOBAL_VBMSGBOXRIGHT             209
> > -#define DISPID_GLOBAL_VBMSGBOXRTLREADING        210
> > +#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON        208
> > +#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND     209
> > +#define DISPID_GLOBAL_VBMSGBOXRIGHT             210
> > +#define DISPID_GLOBAL_VBMSGBOXRTLREADING        211
> >
> > #define DISPID_GLOBAL_CCUR                      100
> >   #define DISPID_GLOBAL_CINT                      101
> > @@ -210,6 +210,7 @@
> >   #define DISPID_GLOBAL_EXECUTE                   204
> >   #define DISPID_GLOBAL_EXECUTEGLOBAL             205
> >   #define DISPID_GLOBAL_GETREF                    206
> > +#define DISPID_GLOBAL_GETLOCALE                 207
>
> This changes are not matching the typelib in native vbscript.dll. It looks
> like GetLocale function is not defined there at all.

So it is unnecessary to implement GetLocale or SetLocale function? I don't
quite understand your word.

[PATCH] vbscript: Implemented GetLocale(try 2)

[Piotr Caban]

On 03/18/15 17:15, Shuai Meng wrote:
> 2015-03-18 18:35 GMT+08:00 Piotr Caban <[e-mail]
> >:
> On 03/17/15 09:29, Shuai Meng wrote:
>
>     -#define DISPID_GLOBAL___VBMSGBOXHELPBUTTON        207
>     -#define DISPID_GLOBAL___VBMSGBOXSETFOREGROUND     208
>     -#define DISPID_GLOBAL_VBMSGBOXRIGHT             209
>     -#define DISPID_GLOBAL___VBMSGBOXRTLREADING        210
>     +#define DISPID_GLOBAL___VBMSGBOXHELPBUTTON        208
>     +#define DISPID_GLOBAL___VBMSGBOXSETFOREGROUND     209
>     +#define DISPID_GLOBAL_VBMSGBOXRIGHT             210
>     +#define DISPID_GLOBAL___VBMSGBOXRTLREADING        211
>
>        #define DISPID_GLOBAL_CCUR                      100
>        #define DISPID_GLOBAL_CINT                      101
>     @@ -210,6 +210,7 @@
>        #define DISPID_GLOBAL_EXECUTE                   204
>        #define DISPID_GLOBAL_EXECUTEGLOBAL             205
>        #define DISPID_GLOBAL_GETREF                    206
>     +#define DISPID_GLOBAL_GETLOCALE                 207
>
> This changes are not matching the typelib in native vbscript.dll. It
> looks like GetLocale function is not defined there at all.
>
>
> So it is unnecessary to implement GetLocale or SetLocale function? I
> don't quite understand your word.

As your test shows the function is implemented in native dll so it 
should be implemented in wine. It's just not defined in typelib.

[PATCH] vbscript: Implemented GetLocale(try 2)

[Shuai Meng]

2015-03-19 0:25 GMT+08:00 Piotr Caban :
> On 03/18/15 17:15, Shuai Meng wrote:
> > 2015-03-18 18:35 GMT+08:00 Piotr Caban <[e-mail]
> > >:
> > On 03/17/15 09:29, Shuai Meng wrote:
> >
> >     -#define DISPID_GLOBAL___VBMSGBOXHELPBUTTON        207
> >     -#define DISPID_GLOBAL___VBMSGBOXSETFOREGROUND     208
> >     -#define DISPID_GLOBAL_VBMSGBOXRIGHT             209
> >     -#define DISPID_GLOBAL___VBMSGBOXRTLREADING        210
> >     +#define DISPID_GLOBAL___VBMSGBOXHELPBUTTON        208
> >     +#define DISPID_GLOBAL___VBMSGBOXSETFOREGROUND     209
> >     +#define DISPID_GLOBAL_VBMSGBOXRIGHT             210
> >     +#define DISPID_GLOBAL___VBMSGBOXRTLREADING        211
> >
> >        #define DISPID_GLOBAL_CCUR                      100
> >        #define DISPID_GLOBAL_CINT                      101
> >     @@ -210,6 +210,7 @@
> >        #define DISPID_GLOBAL_EXECUTE                   204
> >        #define DISPID_GLOBAL_EXECUTEGLOBAL             205
> >        #define DISPID_GLOBAL_GETREF                    206
> >     +#define DISPID_GLOBAL_GETLOCALE                 207
> >
> > This changes are not matching the typelib in native vbscript.dll. It
> > looks like GetLocale function is not defined there at all.
> >
> >
> > So it is unnecessary to implement GetLocale or SetLocale function? I
> > don't quite understand your word.
>
> As your test shows the function is implemented in native dll so it should
> be implemented in wine. It's just not defined in typelib.

I have checked the vbscript.dll on win7, it's true that GetLocale and
SetLocale are not defined in typelib. But then we can't add it to global.c
and vbsglobal.idl, right? I would be appreciated if you can offer some
ideas on how I can implement it.