[PATCH 1/2] ole32/test: Test reentrancy of QueryContinueDrag.

List overview All Threads

newer

older

[PATCH] configure: Use...

[PATCH] wschom/tests: Use wide...

Roman Pišl

16 Feb 2020 16 Feb '20

1:05 p.m.

QueryContinueDrag is not reentrant on Windows.

Signed-off-by: Roman Pišl rpisl@seznam.cz --- dlls/ole32/tests/dragdrop.c | 38 ++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/dlls/ole32/tests/dragdrop.c b/dlls/ole32/tests/dragdrop.c index 77e47d723d..82564a620a 100644 --- a/dlls/ole32/tests/dragdrop.c +++ b/dlls/ole32/tests/dragdrop.c @@ -260,6 +260,7 @@ struct method_call call_lists[][30] = };

static int droptarget_refs; +static int test_reentrance;

/* helper macros to make tests a bit leaner */ #define ok_ole_success(hr, func) ok(hr == S_OK, func " failed with error 0x%08x\n", hr) @@ -359,7 +360,19 @@ static HRESULT WINAPI DropSource_QueryContinueDrag( BOOL fEscapePressed, DWORD grfKeyState) { - return check_expect(DS_QueryContinueDrag, 0, NULL); + HRESULT hr = check_expect(DS_QueryContinueDrag, 0, NULL); + if (test_reentrance) + { + MSG msg; + Sleep(100); + /* run the message loop for this thread */ + while (PeekMessageA(&msg, NULL, 0, 0, PM_REMOVE)) + { + TranslateMessage(&msg); + DispatchMessageA(&msg); + } + } + return hr; }

static HRESULT WINAPI DropSource_GiveFeedback( @@ -701,17 +714,20 @@ static void test_DoDragDrop(void) GetWindowRect(hwnd, &rect); ok(SetCursorPos(rect.left+50, rect.top+50), "SetCursorPos failed\n");

- for (seq = 0; seq < ARRAY_SIZE(call_lists); seq++) + for (test_reentrance = 0; test_reentrance < 2; test_reentrance++) { - DWORD effect_in; - trace("%d\n", seq); - call_ptr = call_lists[seq]; - effect_in = call_ptr->set_param; - call_ptr++; - - hr = DoDragDrop(&DataObject, &DropSource, effect_in, &effect); - check_expect(DoDragDrop_ret, hr, NULL); - check_expect(DoDragDrop_effect_out, effect, NULL); + for (seq = 0; seq < ARRAY_SIZE(call_lists); seq++) + { + DWORD effect_in; + trace("%d\n", seq); + call_ptr = call_lists[seq]; + effect_in = call_ptr->set_param; + call_ptr++; + + hr = DoDragDrop(&DataObject, &DropSource, effect_in, &effect); + check_expect(DoDragDrop_ret, hr, NULL); + check_expect(DoDragDrop_effect_out, effect, NULL); + } }

OleUninitialize();

-- 2.20.1

Show replies by date

Roman Pišl

16 Feb 16 Feb

1:05 p.m.

New subject: [PATCH 2/2] ole32: Avoid calling QueryContinueDrag recursively.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48569

Signed-off-by: Roman Pišl rpisl@seznam.cz --- dlls/ole32/ole2.c | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c index 757458ad20..9d404abba5 100644 --- a/dlls/ole32/ole2.c +++ b/dlls/ole32/ole2.c @@ -62,6 +62,7 @@ typedef struct tagTrackerWindowInfo DWORD dwOKEffect; DWORD* pdwEffect; BOOL trackingDone; + BOOL inTrackCall; HRESULT returnValue;

BOOL escPressed; @@ -767,6 +768,7 @@ HRESULT WINAPI DoDragDrop ( trackerInfo.pdwEffect = pdwEffect; trackerInfo.trackingDone = FALSE; trackerInfo.escPressed = FALSE; + trackerInfo.inTrackCall = FALSE; trackerInfo.curTargetHWND = 0; trackerInfo.curDragTarget = 0;

@@ -2163,7 +2165,11 @@ static LRESULT WINAPI OLEDD_DragTrackerWindowProc( { TrackerWindowInfo *trackerInfo = (TrackerWindowInfo*)GetWindowLongPtrA(hwnd, 0); if (trackerInfo->trackingDone) break; + if (trackerInfo->inTrackCall) break; + + trackerInfo->inTrackCall = TRUE; OLEDD_TrackStateChange(trackerInfo); + trackerInfo->inTrackCall = FALSE; break; } case WM_DESTROY:

-- 2.20.1

Huw Davies

17 Feb 17 Feb

10:27 a.m.

New subject: [PATCH 2/2] ole32: Avoid calling QueryContinueDrag recursively.

On Sun, Feb 16, 2020 at 02:05:36PM +0100, Roman Pišl wrote:

...

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48569

Signed-off-by: Roman Pišl rpisl@seznam.cz

dlls/ole32/ole2.c | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c index 757458ad20..9d404abba5 100644 --- a/dlls/ole32/ole2.c +++ b/dlls/ole32/ole2.c @@ -62,6 +62,7 @@ typedef struct tagTrackerWindowInfo DWORD dwOKEffect; DWORD* pdwEffect; BOOL trackingDone;

BOOL inTrackCall; HRESULT returnValue;

BOOL escPressed;

@@ -767,6 +768,7 @@ HRESULT WINAPI DoDragDrop ( trackerInfo.pdwEffect = pdwEffect; trackerInfo.trackingDone = FALSE; trackerInfo.escPressed = FALSE;

trackerInfo.inTrackCall = FALSE; trackerInfo.curTargetHWND = 0; trackerInfo.curDragTarget = 0;

@@ -2163,7 +2165,11 @@ static LRESULT WINAPI OLEDD_DragTrackerWindowProc( { TrackerWindowInfo *trackerInfo = (TrackerWindowInfo*)GetWindowLongPtrA(hwnd, 0); if (trackerInfo->trackingDone) break;
 if (trackerInfo->inTrackCall) break;
 trackerInfo->inTrackCall = TRUE;
 OLEDD_TrackStateChange(trackerInfo);
 trackerInfo->inTrackCall = FALSE;
 break;
} case WM_DESTROY:

There's a second call to OLEDD_TrackStateChange() in DoDragDrop(). It would probably be better to move the checking and setting of inTrackCall into OLEDD_TrackStateChange() itself.

Huw.

Marvin

16 Feb 16 Feb

1:19 p.m.

Hi,

While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?

Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=65268

Your paranoid android.

=== debian10 (32 bit report) ===

ole32: dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_Drop dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragLeave dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_Drop dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_Drop dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragLeave dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_in dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragEnter dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragOver dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DS_GiveFeedback dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DT_DragLeave dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_ret dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DoDragDrop_effect_out dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of end_seq dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc dragdrop.c:363: Test failed: unexpected call DS_QueryContinueDrag instead of DO_EnumFormatEtc Unhandled exception: page fault on read access to 0x01e81598 in 32-bit code (0x0041dea5).

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49496 bytes)

=== debian10 (32 bit French report) ===

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49511 bytes)

=== debian10 (32 bit Japanese:Japan report) ===

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49511 bytes)

=== debian10 (32 bit Chinese:China report) ===

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49511 bytes)

=== debian10 (32 bit WoW report) ===

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49489 bytes)

=== debian10 (64 bit WoW report) ===

Report validation errors: ole32:dragdrop crashed (c0000005) ole32:dragdrop prints too much data (49504 bytes)

Huw Davies

17 Feb 17 Feb

10:25 a.m.

On Sun, Feb 16, 2020 at 02:05:35PM +0100, Roman Pišl wrote:

...

QueryContinueDrag is not reentrant on Windows.

These tests are failing on Wine before second patch is applied, this means they can't go in as they stand. In this case the simplest solution is to merge both patches.

Huw.

1789

Age (days ago)

1790

Last active (days ago)

wine-devel@winehq.org

4 comments

3 participants

tags (0)

participants (3)

Huw Davies
Marvin
Roman Pišl