Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=78360
Your paranoid android.
=== w10pro64_ja (32 bit report) ===
quartz: videorenderer.c:1078: Test failed: Wait failed. videorenderer.c:1079: Test failed: Got hr 0x103. videorenderer.c:1088: Test failed: Thread should block in Receive().
=== w10pro64_zh_CN (32 bit report) ===
quartz: videorenderer.c:1098: Test failed: Got hr 0x80004005.
=== w10pro64 (64 bit report) ===
quartz: videorenderer.c:1088: Test failed: Thread should block in Receive().
=== w10pro64_2scr (64 bit report) ===
quartz: videorenderer.c:1098: Test failed: Got hr 0x80004005.
=== w10pro64_he (64 bit report) ===
quartz: videorenderer.c:1098: Test failed: Got hr 0x80004005.
=== w10pro64_ja (64 bit report) ===
quartz: videorenderer.c:1098: Test failed: Got hr 0x80004005.
Hi Pengpeng,
On 9/9/20 1:07 PM, Pengpeng Dong wrote:
BaseControlWindowImpl_get_Visible(IVideoWindow *iface, LONG *visi
TRACE("window %p, visible %p.\n", window, visible);
- if(!visible)
return E_POINTER;
Just a nitpick, please add a space after 'if'. Also, IMO, a commit comment like "quartz: Handle NULL visible in IVideoWindow::get_Visible()." might be better. At least, we don't use 'pVisible' as its parameter name anymore.
Thanks for your contribution.