Re: [v8 02/11] ddraw7/tests: Test GetPriority() on cubemap surfaces.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-11-19 um 19:50 schrieb Riccardo Bortolato:
> -
>    {DDSCAPS_TEXTURE | DDSCAPS_COMPLEX | DDSCAPS_MIPMAP,
> -
>            DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_ALLFACES | DDSCAPS2_TEXTUREMANAGE,
> -
>            "cubemap", DDERR_INVALIDPARAMS, FALSE},

If I am reading this right, this means that Get / Set Priority fails on
the positive X top level surface as well (i.e., the root surface
returned by CreateSurface). In that case your test would fail on Wine.

Am I missing something?

(Haven't yet run the test myself because my Wine tree is currently in a
bad rebase-induced shape...)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWThyoAAoJEN0/YqbEcdMw5V8P/je9S0tMvYUxJQbFKCo1vFlF
APAXsmxPPtDVXZ/49Na2/Lc7swwD0b0MMzOnfXK4rnfRq98z4pMl4C56kF51c0gY
16R565K/n6dencFiv/99OHqNc6GvzWDrKCM3zDwMdixPUW3+9Eryj2FqDitzjovI
smmhynlRvnfObrYmtWcvumURluv2rgGm+p04MIq9WtiTwjuhMMRKKDm2PgAMuit0
TboJvUFR4oGQwsbFpmcQIFtzqeOeSe4wGaQ9pwv24gNSnltda3+8epSihrEI59dU
YDTZ8+0y5GiaP4qy/tExAWt33h2b8QMYI3cr8XesEt+t4P9NdjDlt9wkXKikVqmd
72mcQzd3JXxOYWNYAw19wPKh5BoN/dYuZZ4miUh2iNxaxEwQnh88X20DeBQO1zYQ
fCGbmQZ1bsOKMtO0hdVq695Q/HirG6W4t6Do6CL2mwkmu+F0Xrb7wKsAW6zr6ZzX
wVpZSTuRGJJJtpFCAZDNavAo2QAk50hNtlqA1sPiXRo0gdCkAYh7ZuAa9/vYCTVx
XfvD4jOHI0E05AKUnLtxnvEocPvsHmbwCfZVZGLnEamwfYYRzwFKHoxFwS/aHJTW
/KOGA4NPUMHBA4uU+qjvT3Ntoe2qA8ba/UATOqLBayDcxjI5VCIb+XeN53SNdlNv
fEjHWMRADgYlWor6edz+
=8c38
-----END PGP SIGNATURE-----

[v8 02/11] ddraw7/tests: Test GetPriority() on cubemap surfaces.

[Riccardo Bortolato]

2015-11-19 20:02 GMT+01:00 Stefan Dösinger :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2015-11-19 um 19:50 schrieb Riccardo Bortolato:
> > -
> >    {DDSCAPS_TEXTURE | DDSCAPS_COMPLEX | DDSCAPS_MIPMAP,
> > -
> >            DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_ALLFACES | DDSCAPS2_TEXTUREMANAGE,
> > -
> >            "cubemap", DDERR_INVALIDPARAMS, FALSE},
>
> If I am reading this right, this means that Get / Set Priority fails on
> the positive X top level surface as well (i.e., the root surface
> returned by CreateSurface). In that case your test would fail on Wine.
>
> Am I missing something?

Unfortunately you're reading this right, and this means git didn't
save my change while amending/rebasing.

The correct return value here is DD_OK, I will resend asap.

Ciao,
Riccardo
> (Haven't yet run the test myself because my Wine tree is currently in a
> bad rebase-induced shape...)
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWThyoAAoJEN0/YqbEcdMw5V8P/je9S0tMvYUxJQbFKCo1vFlF
> APAXsmxPPtDVXZ/49Na2/Lc7swwD0b0MMzOnfXK4rnfRq98z4pMl4C56kF51c0gY
> 16R565K/n6dencFiv/99OHqNc6GvzWDrKCM3zDwMdixPUW3+9Eryj2FqDitzjovI
> smmhynlRvnfObrYmtWcvumURluv2rgGm+p04MIq9WtiTwjuhMMRKKDm2PgAMuit0
> TboJvUFR4oGQwsbFpmcQIFtzqeOeSe4wGaQ9pwv24gNSnltda3+8epSihrEI59dU
> YDTZ8+0y5GiaP4qy/tExAWt33h2b8QMYI3cr8XesEt+t4P9NdjDlt9wkXKikVqmd
> 72mcQzd3JXxOYWNYAw19wPKh5BoN/dYuZZ4miUh2iNxaxEwQnh88X20DeBQO1zYQ
> fCGbmQZ1bsOKMtO0hdVq695Q/HirG6W4t6Do6CL2mwkmu+F0Xrb7wKsAW6zr6ZzX
> wVpZSTuRGJJJtpFCAZDNavAo2QAk50hNtlqA1sPiXRo0gdCkAYh7ZuAa9/vYCTVx
> XfvD4jOHI0E05AKUnLtxnvEocPvsHmbwCfZVZGLnEamwfYYRzwFKHoxFwS/aHJTW
> /KOGA4NPUMHBA4uU+qjvT3Ntoe2qA8ba/UATOqLBayDcxjI5VCIb+XeN53SNdlNv
> fEjHWMRADgYlWor6edz+
> =8c38
> -----END PGP SIGNATURE-----