Re: [PATCH] configure.ac: use proper quoting throughout the file

[Yann Droneaud]

Hi,

Le lundi 15 mars 2010 à 11:13 +0100, Yann Droneaud a écrit :
> Added quoting around macro parameters as recommanded by autoconf:
> http://www.gnu.org/software/autoconf/manual/html_node/Autoconf-Language.html...
>
> Autoconf output was checked to be the same with and without the patch,
> so that it's easy to validate the patch: configure script is exactly the
> same with or without the patch.
>
> Note: Quoting were not added for WINE macros related to Makefile generation
> as they broke things: there are some quoting magic in aclocal.m4 not
> fixed by this patch.

As stated in the patch log, it can be applied safely.

But once applied on current HEAD, most pending patches on configure.ac
won't apply.

So if this patch is going to be applied, developer must be warned first
and hold their own patches.

I'm ok to hold this one a week or two, so pending patches could be
applied without modification before this one get applied.

I have another patches waiting to fix some autoconf constructs.

Regards.

[PATCH] configure.ac: use proper quoting throughout the file

[Alexandre Julliard]

Yann Droneaud  writes:
> > Note: Quoting were not added for WINE macros related to Makefile generation
> > as they broke things: there are some quoting magic in aclocal.m4 not
> > fixed by this patch.
>
> As stated in the patch log, it can be applied safely.
>
> But once applied on current HEAD, most pending patches on configure.ac
> won't apply.

Which is why the patch won't be applied. There's no need for such a
large scale cleanup. If some macros really have quoting issues you can
fix those and leave the rest alone.

[PATCH] configure.ac: use proper quoting throughout the file

[Yann Droneaud]

Le lundi 15 mars 2010 à 13:05 +0100, Alexandre Julliard a écrit :
> Yann Droneaud  writes:
> > > Note: Quoting were not added for WINE macros related to Makefile generation
> > > as they broke things: there are some quoting magic in aclocal.m4 not
> > > fixed by this patch.
> >
> > As stated in the patch log, it can be applied safely.
> >
> > But once applied on current HEAD, most pending patches on configure.ac
> > won't apply.
>
> Which is why the patch won't be applied. There's no need for such a
> large scale cleanup. If some macros really have quoting issues you can
> fix those and leave the rest alone.

Yes, I can fix only those.

But, the patch was targeting consistency: configure.ac script uses
macros sometimes with proper quoting, sometimes not. There's no rule.

This patch was trying to ensure that all macro calls were written the
same way, so if someone was looking for some copy/paste to add new
tests/new features, only sane default would be used.

So I'm dropping this patch and will send multiple small fix to specific
macro calls.

Regards.