Re: [Resent] Disable CopyImage for IMAGE_BITMAP for now

[Alexandre Julliard]

Uwe Bonnes  writes:
> Changelog:
>         dlls/user/cursoricon.c: CopyImage() for IMAGE_BITMAP
>         Disable for now, code causes memory corruption

Then it should be fixed, not disabled.

[Resent] Disable CopyImage for IMAGE_BITMAP for now

[Uwe Bonnes]

> > > > > "Alexandre" == Alexandre Julliard  writes:

Alexandre> Uwe Bonnes  writes:
    >> Changelog: dlls/user/cursoricon.c: CopyImage() for IMAGE_BITMAP
    >> Disable for now, code causes memory corruption

Alexandre> Then it should be fixed, not disabled.

The present code corrupts the heap in some situation, causing trouble and crashes
hard to correlate to this function for most users. In the other cases it
doesn't work, resulting is garbage displayed.

All those bitmap things are area where I have few knowledge, so I am not the
one to fix it (also I tried some approaches...).

[Resent] Disable CopyImage for IMAGE_BITMAP for now

[Alex Villací­s Lasso]

Uwe Bonnes wrote:
> The present code corrupts the heap in some situation, causing trouble and crashes
> hard to correlate to this function for most users. In the other cases it
> doesn't work, resulting is garbage displayed.
>
> All those bitmap things are area where I have few knowledge, so I am not the
> one to fix it (also I tried some approaches...).

Do you have sample code/applications that experience corruption on 
CopyImage()? This looks like it is related to a problem in which VB6 
apps that use the toolbar control display a garbled transparency on Wine 
(such as MP3GainGUI http://mp3gain.sourceforge.net/). The ideal sample 
would be one with source code that directly calls CopyImage() and gets 
its memory corrupted as a result.

Alex Villacís Lasso

[Resent] Disable CopyImage for IMAGE_BITMAP for now

[Uwe Bonnes]

> > > > > "Alex" == Alex Villací­s Lasso  writes:

>> 
    Alex> Do you have sample code/applications that experience corruption on
    Alex> CopyImage()? This looks like it is related to a problem in which
    Alex> VB6 apps that use the toolbar control display a garbled
    Alex> transparency on Wine (such as MP3GainGUI
    Alex> http://mp3gain.sourceforge.net/). The ideal sample would be one
    Alex> with source code that directly calls CopyImage() and gets its
    Alex> memory corrupted as a result.

My example is Atmel AvrStudio, a 40 MByte download.

I have no sample source code.