Re: ntdll: make shared user data access work

[Alexandre Julliard]

Robert Reif  writes:
> diff -p -u -r1.66 thread.c
> --- dlls/ntdll/thread.c	26 Jul 2006 14:01:20 -0000	1.66
> +++ dlls/ntdll/thread.c	6 Aug 2006 01:15:43 -0000
> @@ -215,7 +215,7 @@ HANDLE thread_init(void)
>  addr = (void *)0x7ffe0000;
>  size = 0x10000;
> - NtAllocateVirtualMemory( NtCurrentProcess(), &addr, 0, &size, MEM_RESERVE, PAGE_READONLY );
> - NtAllocateVirtualMemory( NtCurrentProcess(), &addr, 0, &size, MEM_RESERVE | MEM_COMMIT, PAGE_READONLY);

This code is only intended to reserve the space at startup. We need to
initialize it properly later on before making it accessible.

ntdll: make shared user data access work

[Robert Reif]

Alexandre Julliard wrote:
> Robert Reif  writes:
> > diff -p -u -r1.66 thread.c
> > --- dlls/ntdll/thread.c	26 Jul 2006 14:01:20 -0000	1.66
> > +++ dlls/ntdll/thread.c	6 Aug 2006 01:15:43 -0000
> > @@ -215,7 +215,7 @@ HANDLE thread_init(void)
> > addr = (void *)0x7ffe0000;
> > size = 0x10000;
> > - NtAllocateVirtualMemory( NtCurrentProcess(), &addr, 0, &size, MEM_RESERVE, PAGE_READONLY );
> > - NtAllocateVirtualMemory( NtCurrentProcess(), &addr, 0, &size, MEM_RESERVE | MEM_COMMIT, PAGE_READONLY);
>
> This code is only intended to reserve the space at startup. We need to
> initialize it properly later on before making it accessible.

Technically, the server should probably create, initialize and update 
this memory and each thread should just get their own read only mapping .

This patch is just a quick fix to prevent a crash when an application or 
dll tries to read from that memory.  I guess this is the equivalent of a 
stub function.

ntdll: make shared user data access work

[Alexandre Julliard]

Robert Reif  writes:
> This patch is just a quick fix to prevent a crash when an application
> or dll tries to read from that memory.  I guess this is the equivalent
> of a stub function.

The problem is that there's no FIXME being printed, so unlike with
stubs things will most likely fail silently. BTW which app is using
this, and which part of the data does it need?