Re: [PATCH 3/3] kernel32: Add GetThreadIOPendingFlag tests

[Dmitry Timoshkov]

Piotr Caban  wrote:
> - char path[16384] = {0};

...
> - r = GetTempPathA(MAX_PATH, path);
> - ok(r, "GetTempPathA error: %u\n", GetLastError());
> - lstrcatA(path, "testIOPendingFlag");
> - r = CreateDirectoryA(path, NULL);
> - ok(r, "CreateDirectoryA error: %d\n", GetLastError());

Why path[MAX_PATH] is not enough? Also you need to remove the created
directory at the end of the test.

[PATCH 3/3] kernel32: Add GetThreadIOPendingFlag tests

[Piotr Caban]

Hi Dmitry,

On 02/03/17 07:42, Dmitry Timoshkov wrote:
> Why path[MAX_PATH] is not enough?

The path variable is also used as a buffer passed to WriteFile call. It 
needs to be that big to workaround a bug related to pipes buffer sizes 
in wine.

Also you need to remove the created
> directory at the end of the test.

The directory is already removed in the test.

Thanks,
Piotr

[PATCH 3/3] kernel32: Add GetThreadIOPendingFlag tests

[Dmitry Timoshkov]

Piotr Caban  wrote:
> Also you need to remove the created
> > directory at the end of the test.
>
> The directory is already removed in the test.

Sorry, missed the RemoveDirectory() call, it appears to be buried well
enough in the midle of the tests.