[PATCH 1/2] ntdll: use proper names for magic constants

[Eric Pouech]

Signed-off-by: Eric Pouech

---
 dlls/ntdll/unix/process.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/unix/process.c b/dlls/ntdll/unix/process.c
index 23aa340359e..99c8e37053c 100644
--- a/dlls/ntdll/unix/process.c
+++ b/dlls/ntdll/unix/process.c
@@ -444,7 +444,7 @@ static NTSTATUS spawn_process( const RTL_USER_PROCESS_PARAMETERS *params, int so
         if (!(pid = fork()))  /* grandchild */
         {
             if (params->ConsoleFlags ||
-                params->ConsoleHandle == (HANDLE)1 /* KERNEL32_CONSOLE_ALLOC */ ||
+                params->ConsoleHandle == CONSOLE_HANDLE_ALLOC ||
                 (params->hStdInput == INVALID_HANDLE_VALUE && params->hStdOutput == INVALID_HANDLE_VALUE))
             {
                 setsid();

[PATCH 2/2] kernelbase: fix comment (name of magic constant has changed)

[Eric Pouech]

Signed-off-by: Eric Pouech

---
 dlls/kernelbase/process.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c
index 0e4a3eb9b6b..0d53684b203 100644
--- a/dlls/kernelbase/process.c
+++ b/dlls/kernelbase/process.c
@@ -189,7 +189,7 @@ static RTL_USER_PROCESS_PARAMETERS *create_process_params( const WCHAR *filename
     RtlFreeUnicodeString( &newdirW );

if (flags & CREATE_NEW_PROCESS_GROUP) params->ConsoleFlags = 1;
-    if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = (HANDLE)1; /* KERNEL32_CONSOLE_ALLOC */
+    if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = (HANDLE)1; /* CONSOLE_HANDLE_ALLOC */
     else if (!(flags & DETACHED_PROCESS)) params->ConsoleHandle = NtCurrentTeb()->Peb->ProcessParameters->ConsoleHandle;

if (startup->dwFlags & STARTF_USESTDHANDLES)

[PATCH 2/2] kernelbase: fix comment (name of magic constant has changed)

[Jacek Caban]

On 12/17/21 3:58 PM, Eric Pouech wrote:
> Signed-off-by: Eric Pouech
>
> dlls/kernelbase/process.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c
> index 0e4a3eb9b6b..0d53684b203 100644
> --- a/dlls/kernelbase/process.c
> +++ b/dlls/kernelbase/process.c
> @@ -189,7 +189,7 @@ static RTL_USER_PROCESS_PARAMETERS *create_process_params( const WCHAR *filename
>       RtlFreeUnicodeString( &newdirW );
>   if (flags & CREATE_NEW_PROCESS_GROUP) params->ConsoleFlags = 1;
> - if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = (HANDLE)1; /* KERNEL32_CONSOLE_ALLOC */
> - if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = (HANDLE)1; /* CONSOLE_HANDLE_ALLOC */

I think we can just use condrv.h here now.

Thanks,

Jacek

[PATCH 2/2] kernelbase: fix comment (name of magic constant has changed)

[Eric Pouech]

Le 17/12/2021 à 16:14, Jacek Caban a écrit :
> On 12/17/21 3:58 PM, Eric Pouech wrote:
> > Signed-off-by: Eric Pouech
> >
> > dlls/kernelbase/process.c |    2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c
> > index 0e4a3eb9b6b..0d53684b203 100644
> > --- a/dlls/kernelbase/process.c
> > +++ b/dlls/kernelbase/process.c
> > @@ -189,7 +189,7 @@ static RTL_USER_PROCESS_PARAMETERS 
> > *create_process_params( const WCHAR *filename
> >       RtlFreeUnicodeString( &newdirW );
> >         if (flags & CREATE_NEW_PROCESS_GROUP) params->ConsoleFlags = 1;
> > -    if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = 
> > (HANDLE)1; /* KERNEL32_CONSOLE_ALLOC */
> > +    if (flags & CREATE_NEW_CONSOLE) params->ConsoleHandle = 
> > (HANDLE)1; /* CONSOLE_HANDLE_ALLOC */
>
> I think we can just use condrv.h here now.
>
> Thanks,
>
> Jacek

I didn't want to do add this change in code freeze ;-)

[Jacek Caban]

Signed-off-by: Jacek Caban