Re: [SETUPAPI] fix bug 1140

[Alexandre Julliard]

Raphael  writes:
> patch who correct bug 1140 (http://bugs.winehq.org/show_bug.cgi?id=1140), 
> htmlhelp install is success :)
>
> Changelog:
> - fix GenFormStrWithoutPlaceHolders16 
>  ie fix PARSER_string_substW to only keep valid texts entries (no comments
>
> or tabs)

This is wrong, comments should have already been taken into account
when PARSER_string_substW is called. The right fix is to make
GenFormStrWithoutPlaceHolders16 properly split the line like the
32-bit functions do.

[SETUPAPI] fix bug 1140

[Raphael]

On Wednesday 16 March 2005 19:57, Alexandre Julliard wrote:
> Raphael  writes:
> > patch who correct bug 1140 (http://bugs.winehq.org/show_bug.cgi?id=1140),
> > htmlhelp install is success :)
> >
> > Changelog:
> > - fix GenFormStrWithoutPlaceHolders16
> >  ie fix PARSER_string_substW to only keep valid texts entries (no
> >
> > comments or tabs)
>
> This is wrong, comments should have already been taken into account
> when PARSER_string_substW is called. The right fix is to make
> GenFormStrWithoutPlaceHolders16 properly split the line like the
> 32-bit functions do.

Ok, and this one ?

Regards,
Raphael

[SETUPAPI] fix bug 1140

[Alexandre Julliard]

Raphael  writes:
> On Wednesday 16 March 2005 19:57, Alexandre Julliard wrote:
> > This is wrong, comments should have already been taken into account
> > when PARSER_string_substW is called. The right fix is to make
> > GenFormStrWithoutPlaceHolders16 properly split the line like the
> > 32-bit functions do.
>
> Ok, and this one ?

I think you should take into account quotes and the like.