[PATCH V3 1/5] dlls/kernel32/tests: move CreateProcess() handle inheritance test into a dedicated function
Signed-off-by: Eric Pouech eric.pouech@gmail.com
--- dlls/kernel32/tests/process.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 8f18a0d37a7..e7b4f30b565 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1521,10 +1521,6 @@ static void test_Console(void) CONSOLE_SCREEN_BUFFER_INFO sbi, sbiC; DWORD modeIn, modeOut, modeInC, modeOutC; DWORD cpIn, cpOut, cpInC, cpOutC; - DWORD w; - HANDLE hChildIn, hChildInInh, hChildOut, hChildOutInh, hParentIn, hParentOut; - const char* msg = "This is a std-handle inheritance test."; - unsigned msg_len; BOOL run_tests = TRUE; char *result;
@@ -1647,6 +1643,17 @@ static void test_Console(void)
release_memory(); DeleteFileA(resfile); +} + +static void test_StdInheritance(void) +{ + char buffer[2 * MAX_PATH + 35]; + PROCESS_INFORMATION info; + STARTUPINFOA startup; + DWORD w; + HANDLE hChildIn, hChildInInh, hChildOut, hChildOutInh, hParentIn, hParentOut; + const char* msg = "This is a std-handle inheritance test."; + unsigned msg_len;
ok(CreatePipe(&hParentIn, &hChildOut, NULL, 0), "Creating parent-input pipe\n"); ok(DuplicateHandle(GetCurrentProcess(), hChildOut, GetCurrentProcess(), @@ -5095,6 +5102,7 @@ START_TEST(process) test_SuspendFlag(); test_DebuggingFlag(); test_Console(); + test_StdInheritance(); test_ExitCode(); test_OpenProcess(); test_GetProcessVersion();
there are locale where conhost.exe under Wine fails at startup (when TranslateCharsetInfo( GetACP() ... ) fails)
skip this case
Signed-off-by: Eric Pouech eric.pouech@gmail.com
--- dlls/kernel32/tests/process.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index e7b4f30b565..f61b91a1974 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1540,7 +1540,14 @@ static void test_Console(void) if (!is_console(startup.hStdInput) || !is_console(startup.hStdOutput)) { /* we're not attached to a console, let's do it */ - AllocConsole(); + if (!AllocConsole() || GetConsoleCP() == 0) + { + /* if no console is has been created, this whole test will only produce errors + * (this happens on Wine for some locale) + */ + skip("Skipping console test (conhost.exe aborted)\n"); + return; + } startup.hStdInput = CreateFileA("CONIN$", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0); startup.hStdOutput = CreateFileA("CONOUT$", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0); }
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=113065
Your paranoid android.
=== w10pro64_ja (64 bit report) ===
kernel32: process.c:4989: Test failed: got 0xc0000004 process.c:5007: Test failed: got services.exe SessionId 1
Eric Pouech eric.pouech@gmail.com writes:
there are locale where conhost.exe under Wine fails at startup (when TranslateCharsetInfo( GetACP() ... ) fails)
It sounds like something we need to fix instead of skipping the test.
Le 21/04/2022 à 14:47, Alexandre Julliard a écrit :
Eric Pouecheric.pouech@gmail.com writes:
there are locale where conhost.exe under Wine fails at startup (when TranslateCharsetInfo( GetACP() ... ) fails)
It sounds like something we need to fix instead of skipping the test.
well, I though the patches weren't committed because of the failing tests...
but that's a rather strange situation
tests were failing on some locale
the createprocess on CUI subsystem process broke some more tests in kernel32 (that's the situation reflected by marvin after patch #1 which is a no op)
tests were broken (partly only testing win7 behavior)
the serie solves at least the last two issues
so I'm puzzled concerning the way to go regarding this serie
TIA
This patch shall let this kernel32:process test pass when run from TestBot.
Note: adapted the tests to non Win7 type of handles (the ones with 2 lower bits set...). Windows 8 and above use real handles for console. Wine has been doing so since since 2 years.
The is_console() helper is not testing what its name pretends. It actually tests whether we're running the test on W7 :-( So let's get rid of it.
Signed-off-by: Eric Pouech eric.pouech@gmail.com
--- dlls/kernel32/tests/process.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index f61b91a1974..b6dd70399d3 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1537,8 +1537,13 @@ static void test_Console(void) startup.hStdOutput = CreateFileA("CONOUT$", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0);
/* first, we need to be sure we're attached to a console */ - if (!is_console(startup.hStdInput) || !is_console(startup.hStdOutput)) + if (startup.hStdInput == INVALID_HANDLE_VALUE || startup.hStdOutput == INVALID_HANDLE_VALUE) { + /* this fails either when this test process is run detached from console + * (unlikely, as this very process must be explicitely created with detached flag), + * or is attached to a Wine's shell-no-window kind of console (if the later, detach from it) + */ + FreeConsole(); /* we're not attached to a console, let's do it */ if (!AllocConsole() || GetConsoleCP() == 0) {
This test hadn't been changed with console rewrite. The status before this patch: - it's not run on Windows except Win7 - it's not run on Wine
Rewrite it so that it run on all cases and inverse the test logic (it was only testing Win7 behavior, which is no longer what we want).
Signed-off-by: Eric Pouech eric.pouech@gmail.com
--- dlls/kernel32/tests/process.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index b6dd70399d3..88556ac0c1f 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1507,11 +1507,6 @@ static void test_DebuggingFlag(void) DeleteFileA(resfile); }
-static BOOL is_console(HANDLE h) -{ - return h != INVALID_HANDLE_VALUE && ((ULONG_PTR)h & 3) == 3; -} - static void test_Console(void) { char buffer[2 * MAX_PATH + 35]; @@ -2514,17 +2509,11 @@ static void test_DuplicateHandle(void) DeleteFileA(file_name);
f = CreateFileA("CONIN$", GENERIC_READ|GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, 0); - if (!is_console(f)) - { - skip("DuplicateHandle on console handle\n"); - CloseHandle(f); - return; - } - + ok(f != INVALID_HANDLE_VALUE, "Failed to open CONIN$ %lu\n", GetLastError()); r = DuplicateHandle(GetCurrentProcess(), f, GetCurrentProcess(), &out, 0, FALSE, DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE); ok(r, "DuplicateHandle error %lu\n", GetLastError()); - todo_wine ok(f != out, "f == out\n"); + ok(f == out || broken(/* Win7 */ (((ULONG_PTR)f & 3) == 3) && (f != out)), "f != out\n"); CloseHandle(out); }
V2: - fix broken results on Win7
Signed-off-by: Eric Pouech eric.pouech@gmail.com
--- dlls/kernel32/tests/process.c | 94 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+), 1 deletion(-)
diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 88556ac0c1f..1e25b68abe5 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -336,7 +336,8 @@ static void doChild(const char* file, const char* option) HANDLE hFile = CreateFileA(file, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0); HANDLE snapshot; PROCESSENTRY32 pe; - BOOL ret; + BOOL ret, bin, bout, berr; + DWORD flin, flout, flerr;
if (hFile == INVALID_HANDLE_VALUE) return;
@@ -451,6 +452,18 @@ static void doChild(const char* file, const char* option) childPrintf(hFile, "CurrDirW=%s\n", encodeW(bufW)); childPrintf(hFile, "\n");
+ bin = GetHandleInformation(GetStdHandle(STD_INPUT_HANDLE), &flin); + bout = GetHandleInformation(GetStdHandle(STD_OUTPUT_HANDLE), &flout); + berr = GetHandleInformation(GetStdHandle(STD_ERROR_HANDLE), &flerr); + if (bin || bout || berr) + { + childPrintf(hFile, "[StdHandleInfo]\n"); + if (bin ) childPrintf(hFile, "hStdInput=%lu\n", flin); + if (bout) childPrintf(hFile, "hStdOutput=%lu\n", flout); + if (berr) childPrintf(hFile, "hStdError=%lu\n", flerr); + childPrintf(hFile, "\n"); + } + if (option && strcmp(option, "console") == 0) { CONSOLE_SCREEN_BUFFER_INFO sbi; @@ -523,6 +536,15 @@ static void doChild(const char* file, const char* option) CloseHandle(hFile); }
+static BOOL isChildPresent( const char* sect, const char* key ) +{ + char buf[1024+4*MAX_LISTED_ENV_VAR]; + + GetPrivateProfileStringA(sect, key, "-", buf, sizeof(buf), resfile); + if (buf[0] == '\0' || (buf[0] == '-' && buf[1] == '\0')) return FALSE; + return TRUE; +} + static char* getChildString(const char* sect, const char* key) { char buf[1024+4*MAX_LISTED_ENV_VAR]; @@ -614,10 +636,17 @@ static void ok_child_int( int line, const char *sect, const char *key, UINT expe ok_(__FILE__, line)( result == expect, "%s:%s expected %u, but got %u\n", sect, key, expect, result ); }
+static void ok_child_intbrk( int line, const char *sect, const char *key, UINT expect, UINT brk ) +{ + UINT result = GetPrivateProfileIntA( sect, key, !expect, resfile ); + ok_(__FILE__, line)( result == expect || broken(result == brk), "%s:%s expected %u, but got %u\n", sect, key, expect, result ); +} + #define okChildString(sect, key, expect) ok_child_string(__LINE__, (sect), (key), (expect), 1 ) #define okChildIString(sect, key, expect) ok_child_string(__LINE__, (sect), (key), (expect), 0 ) #define okChildStringWA(sect, key, expect) ok_child_stringWA(__LINE__, (sect), (key), (expect), 1 ) #define okChildInt(sect, key, expect) ok_child_int(__LINE__, (sect), (key), (expect)) +#define okChildIntBroken(sect, key, expect, brk) ok_child_intbrk(__LINE__, (sect), (key), (expect), (brk))
static void test_Startup(void) { @@ -1656,6 +1685,7 @@ static void test_StdInheritance(void) { char buffer[2 * MAX_PATH + 35]; PROCESS_INFORMATION info; + SECURITY_ATTRIBUTES sa; STARTUPINFOA startup; DWORD w; HANDLE hChildIn, hChildInInh, hChildOut, hChildOutInh, hParentIn, hParentOut; @@ -1705,6 +1735,68 @@ static void test_StdInheritance(void)
release_memory(); DeleteFileA(resfile); + + sa.nLength = sizeof(sa); + sa.lpSecurityDescriptor = NULL; + sa.bInheritHandle = TRUE; + + /* test passing in startupinfo inheritable and non inheritable handles (CreateProcess not inheriting handles) */ + memset(&startup, 0, sizeof(startup)); + startup.cb = sizeof(startup); + startup.dwFlags = STARTF_USESTDHANDLES; + startup.hStdInput = CreateFileA("NUL", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0); + startup.hStdOutput = CreateFileA("NUL", GENERIC_READ|GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, 0); + startup.hStdError = (HANDLE)(DWORD_PTR)0x00585840; + ok(startup.hStdInput != INVALID_HANDLE_VALUE, "failed to open NUL\n"); + ok(startup.hStdOutput != INVALID_HANDLE_VALUE, "failed to open NUL\n"); + sprintf(buffer, ""%s" process dump "%s"", selfname, resfile); + ok(CreateProcessA(NULL, buffer, NULL, NULL, FALSE, 0, NULL, NULL, &startup, &info), "CreateProcess\n"); + wait_and_close_child_process(&info); + CloseHandle(startup.hStdInput); + + reload_child_info(resfile); + /* handles values have been zero:ed */ + todo_wine okChildIntBroken("StartupInfoA", "hStdInput", 0, /* Win7 */ (DWORD_PTR)startup.hStdInput); + todo_wine okChildIntBroken("StartupInfoA", "hStdOutput", 0, /* Win7 */ (DWORD_PTR)startup.hStdOutput); + todo_wine okChildIntBroken("StartupInfoA", "hStdError", 0, /* Win7 */ (DWORD_PTR)startup.hStdError); + todo_wine okChildIntBroken("StartupInfoW", "hStdInput", 0, /* Win7 */ (DWORD_PTR)startup.hStdInput); + todo_wine okChildIntBroken("StartupInfoW", "hStdOutput", 0, /* Win7 */ (DWORD_PTR)startup.hStdOutput); + todo_wine okChildIntBroken("StartupInfoW", "hStdError", 0, /* Win7 */ (DWORD_PTR)startup.hStdError); + /* even inheritable objects are not inherited */ + todo_wine ok(!isChildPresent("StdHandleInfo", "hStdInput"), "hStdInput shouldn't be present\n"); + todo_wine ok(!isChildPresent("StdHandleInfo", "hStdOutput"), "hStdOuput shouldn't be present\n"); + ok(!isChildPresent("StdHandleInfo", "hStdError"), "hStdError shouldn't be present\n"); + release_memory(); + DeleteFileA(resfile); + + /* test passing in startupinfo inheritable and non inheritable handles (CreateProcess inhering handles)) */ + memset(&startup, 0, sizeof(startup)); + startup.cb = sizeof(startup); + startup.dwFlags = STARTF_USESTDHANDLES; + startup.hStdInput = CreateFileA("NUL", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0); + startup.hStdOutput = CreateFileA("NUL", GENERIC_READ|GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, 0); + startup.hStdError = (HANDLE)(DWORD_PTR)0x00585840; + ok(startup.hStdInput != INVALID_HANDLE_VALUE, "failed to open NUL\n"); + ok(startup.hStdOutput != INVALID_HANDLE_VALUE, "failed to open NUL\n"); + sprintf(buffer, ""%s" process dump "%s"", selfname, resfile); + ok(CreateProcessA(NULL, buffer, NULL, NULL, TRUE, 0, NULL, NULL, &startup, &info), "CreateProcess\n"); + wait_and_close_child_process(&info); + CloseHandle(startup.hStdInput); + + reload_child_info(resfile); + /* handles values are available */ + okChildInt("StartupInfoA", "hStdInput", (DWORD_PTR)startup.hStdInput); + okChildInt("StartupInfoA", "hStdOutput", (DWORD_PTR)startup.hStdOutput); + okChildInt("StartupInfoA", "hStdError", (DWORD_PTR)startup.hStdError); + okChildInt("StartupInfoW", "hStdInput", (DWORD_PTR)startup.hStdInput); + okChildInt("StartupInfoW", "hStdOutput", (DWORD_PTR)startup.hStdOutput); + okChildInt("StartupInfoW", "hStdError", (DWORD_PTR)startup.hStdError); + /* only inheritable objects are inherited */ + okChildInt("StdHandleInfo", "hStdInput", HANDLE_FLAG_INHERIT); + ok(!isChildPresent("StdHandleInfo", "hStdOutput"), "hStdOutput shouldn't be present\n"); + ok(!isChildPresent("StdHandleInfo", "hStdError"), "hStdError shouldn't be present\n"); + release_memory(); + DeleteFileA(resfile); }
static void test_ExitCode(void)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=113064
Your paranoid android.
=== debian11 (32 bit report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit Arabic:Morocco report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit German report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit French report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit Hebrew:Israel report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit Hindi:India report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit Japanese:Japan report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit Chinese:China report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (32 bit WoW report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 1, but got 0 process.c:1618: Test failed: Console:SizeY expected 0, but got 1 process.c:1619: Test failed: Console:CursorX expected 1, but got 0 process.c:1620: Test failed: Console:CursorY expected 0, but got 1 process.c:1623: Test failed: Console:winTop expected 0, but got 1 process.c:1624: Test failed: Console:winRight expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1627: Test failed: Console:maxWinHeight expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 68, but got 0 process.c:1631: Test failed: Console:OutputMode expected 0, but got 1
=== debian11 (64 bit WoW report) ===
kernel32: process.c:1617: Test failed: Console:SizeX expected 0, but got 1 process.c:1621: Test failed: Console:Attributes expected 0, but got 1 process.c:1625: Test failed: Console:winBottom expected 0, but got 1 process.c:1626: Test failed: Console:maxWinWidth expected 0, but got 1 process.c:1630: Test failed: Console:InputMode expected 0, but got 1
Le 21/04/2022 à 11:34, Marvin a écrit :
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=113064
Your paranoid android.
all these generated errors are what the 2 next patches are fixing
A+
-
Alexandre Julliard -
Eric Pouech -
Eric Pouech -
Marvin