Hans Leidekker hans@it.vu.nl writes:
Tested on Win2k and Win98. MoveFile returns ERROR_ALREADY_EXISTS when the destination exists.
-Hans
Changelog MoveFile returns ERROR_ALREADY_EXISTS, not ERROR_FILE_EXISTS
You need to fix the code too, or add a todo_wine; I can't commit tests that fail.
Alexandre Julliard julliard@winehq.org writes:
You need to fix the code too, or add a todo_wine; I can't commit tests that fail.
What's your policy if it's not possible? Like in my (unapplied) http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html patch, where tests are done in a loop, and some of them succeed, some fail? Or is there something else wrong with that?
Feri.
Ferenc Wagner wferi@afavant.elte.hu writes:
What's your policy if it's not possible? Like in my (unapplied) http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html patch, where tests are done in a loop, and some of them succeed, some fail? Or is there something else wrong with that?
It's always possible, you can add a todo flag in the array so that you can do a todo_wine in appropriate cases, several existing tests do that already. I'll never commit a patch that causes make test to fail on my machine, that would make the regression test suite useless.
Alexandre Julliard julliard@winehq.org writes:
Ferenc Wagner wferi@afavant.elte.hu writes:
What's your policy if it's not possible? Like in my (unapplied) http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html patch, where tests are done in a loop, and some of them succeed, some fail? Or is there something else wrong with that?
It's always possible, you can add a todo flag in the array so that you can do a todo_wine in appropriate cases, several existing tests do that already.
(blush) Including one written by stupid myself... As a pathetic excuse: no wonder I tried to forget it, I had to go through too many ugly hoops to get that Right. And now I will shut up and rewrite this patch, too. Sorry for the noise!
Later, Feri.
On Sunday 14 December 2003 22:04, Ferenc Wagner wrote:
What's your policy if it's not possible? Like in my (unapplied) http://www.winehq.org/hypermail/wine-patches/2003/10/0411.html patch, where tests are done in a loop, and some of them succeed, some fail? Or is there something else wrong with that?
I'm not Alexandre, but that would likely be a case for todo_wine{}, around or within the loop I guess.
-Hans
On Sunday 14 December 2003 21:23, Alexandre Julliard wrote:
You need to fix the code too, or add a todo_wine; I can't commit tests that fail.
Of course, you're right. Here's a fix.
Changelog: MoveFile returns ERROR_ALREADY_EXISTS, not ERROR_FILE_EXISTS
-
Alexandre Julliard -
Ferenc Wagner -
Hans Leidekker