I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?
On 5/11/2014 21:17, Mikael Ståldal wrote:
I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?
If a patch doesn't contain test file changes there's nothing for testbot to do, for Windows VMs I mean.
Usually it make sense to run the test suite anyway, to catch regressions. Changes in the regular code might break an existing test.
On 2014-05-11 19:20, Nikolay Sivov wrote:
On 5/11/2014 21:17, Mikael Ståldal wrote:
I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?
If a patch doesn't contain test file changes there's nothing for testbot to do, for Windows VMs I mean.
On 5/11/2014 21:33, Mikael Ståldal wrote:
Usually it make sense to run the test suite anyway, to catch regressions. Changes in the regular code might break an existing test.
No, wine code changes are irrelevant when you run a test on Windows. Testbot currently runs on Windows VMs only.
On 2014-05-11 19:20, Nikolay Sivov wrote:
On 5/11/2014 21:17, Mikael Ståldal wrote:
I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?
If a patch doesn't contain test file changes there's nothing for testbot to do, for Windows VMs I mean.
On 5/11/2014 21:33, Mikael Ståldal wrote:
Usually it make sense to run the test suite anyway, to catch regressions. Changes in the regular code might break an existing test.
This is true however for some parts of Wine, like widl for example.
On 2014-05-11 19:20, Nikolay Sivov wrote:
On 5/11/2014 21:17, Mikael Ståldal wrote:
I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?
If a patch doesn't contain test file changes there's nothing for testbot to do, for Windows VMs I mean.
-
Mikael Ståldal -
Nikolay Sivov