Re: oleaut32: Build language resource files separately

[Michael Stefaniuc]

Hello Nikolay,

Nikolay Sivov wrote:
> Michael Stefaniuc wrote:
> > instead of including them from an other rc file.
>
> What is the purpose of these changes? I'm not talking it's wring :),
> just interested.

Well, Alexandre did the first patch for programs/clock
http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
so it must be right ;). It increases the resilience as errors in one
language rc file do not propagate to the other languages. There might be
some other reason but I forgot. Alexandre asked me if I could do it as
it is an easy search and replace style janitorial job.

bye
    michael

oleaut32: Build language resource files separately

[Nikolay Sivov]

Michael Stefaniuc wrote:
> Hello Nikolay,
>
> Nikolay Sivov wrote:
> > Michael Stefaniuc wrote:
> > > instead of including them from an other rc file.
> >
> > What is the purpose of these changes? I'm not talking it's wring :),
> > just interested.
>
> Well, Alexandre did the first patch for programs/clock
> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
> so it must be right ;).

Didn't spot that, sorry.
> It increases the resilience as errors in one
> language rc file do not propagate to the other languages. There might be
> some other reason but I forgot. Alexandre asked me if I could do it as
> it is an easy search and replace style janitorial job.
>
> bye
>    michael

Thanks for reply.

oleaut32: Build language resource files separately

[Paul Vriens]

Michael Stefaniuc wrote:
> Hello Nikolay,
>
> Nikolay Sivov wrote:
> > Michael Stefaniuc wrote:
> > > instead of including them from an other rc file.
> >
> > What is the purpose of these changes? I'm not talking it's wring :),
> > just interested.
>
> Well, Alexandre did the first patch for programs/clock
> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
> so it must be right ;). It increases the resilience as errors in one
> language rc file do not propagate to the other languages. There might be
> some other reason but I forgot. Alexandre asked me if I could do it as
> it is an easy search and replace style janitorial job.
>
> bye
>    michael

Well the next steps could be:

- unify the names of the resource files <dll>_<countrycode>.rc
- have make_makefiles do the real work so we don't have to change the 
makefile manually.

(not sure if that first step is needed or if we could just check for all 
.rc files).

oleaut32: Build language resource files separately

[Michael Stefaniuc]

Paul Vriens wrote:
> Michael Stefaniuc wrote:
> > Hello Nikolay,
> >
> > Nikolay Sivov wrote:
> > > Michael Stefaniuc wrote:
> > > > instead of including them from an other rc file.
> > >
> > > What is the purpose of these changes? I'm not talking it's wring :),
> > > just interested.
> >
> > Well, Alexandre did the first patch for programs/clock
> > http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
> >
> > so it must be right ;). It increases the resilience as errors in one
> > language rc file do not propagate to the other languages. There might be
> > some other reason but I forgot. Alexandre asked me if I could do it as
> > it is an easy search and replace style janitorial job.
>
> Well the next steps could be:
> - unify the names of the resource files <dll>_<countrycode>.rc

I hate those names. <countrycode>.rc is so much easier to find and access.
> - have make_makefiles do the real work so we don't have to change the
>
> makefile manually.
>
> (not sure if that first step is needed or if we could just check for all
> .rc files).

Well, we had at one point in time commented out included of language rc
files. If a big change invalidates a rc file (doesn't build anymore) it
is easy to workaround by temporary removing the culprit rc file from the
Makefile.in. If instead all rc files are build and linked automatically
one would have to git rm the broken rc files.

bye
    michael

oleaut32: Build language resource files separately

[Alexandre Julliard]

Michael Stefaniuc  writes:
> Well, Alexandre did the first patch for programs/clock
> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
> so it must be right ;). It increases the resilience as errors in one
> language rc file do not propagate to the other languages. There might be
> some other reason but I forgot. Alexandre asked me if I could do it as
> it is an easy search and replace style janitorial job.

Another reason is that it makes it possible to update the makefile
automatically when a resource file is added.

BTW 8-bit chars are mangled in most of your patches...

oleaut32: Build language resource files separately

[Michael Stefaniuc]

Alexandre Julliard wrote:
> Michael Stefaniuc  writes:
> > Well, Alexandre did the first patch for programs/clock
> > http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a93421...
> > so it must be right ;). It increases the resilience as errors in one
> > language rc file do not propagate to the other languages. There might be
> > some other reason but I forgot. Alexandre asked me if I could do it as
> > it is an easy search and replace style janitorial job.
>
> Another reason is that it makes it possible to update the makefile
> automatically when a resource file is added.
>
> BTW 8-bit chars are mangled in most of your patches...

I really *HATE* mutt's handling of 8bit emails. It always detects the
character set wrong aka as UTF-8 and git checks that the file really is
UTF-8. I'm resending the affected files.

thanks
bye
    michael