Re: winedevice: eliminate some globals

[Alexandre Julliard]

Damjan Jovanovic  writes:
> Changelog:
> - winedevice: eliminate some globals
>
> The long term goal of this patch is to make the driver loading code
> reusable for loading drivers outside winedevice, for use with USB
> drivers etc.

It doesn't work here:

../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok
file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3
file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3
file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3
file.c:944: Test failed: CreateFileA failed on \?\C:, hFile 0xffffffff, err=2, should be 0
file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for \?\C:\ err=5 should be 3
file.c:1000: Test failed: CreateFileA did not open \?\C:, last error=2
file.c:1059: Test failed: CreateFileA did not open \.\C:, last error=2
file.c:1078: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:, last error=2
file.c:1157: Test failed: GetVolumeNameForVolumeMountPointA not functioning
make: *** [file.ok] Error 5

winedevice: eliminate some globals

[Damjan Jovanovic]

On Fri, Apr 15, 2011 at 3:43 PM, Alexandre Julliard  wrote:
> Damjan Jovanovic  writes:
> > Changelog:
> > - winedevice: eliminate some globals
> >
> > The long term goal of this patch is to make the driver loading code
> > reusable for loading drivers outside winedevice, for use with USB
> > drivers etc.
>
> It doesn't work here:
>
> ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok
> file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3
> file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3
> file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3
> file.c:944: Test failed: CreateFileA failed on \?\C:, hFile 0xffffffff, err=2, should be 0
> file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for \?\C:\ err=5 should be 3
> file.c:1000: Test failed: CreateFileA did not open \?\C:, last error=2
> file.c:1059: Test failed: CreateFileA did not open \.\C:, last error=2
> file.c:1078: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:, last error=2
> file.c:1157: Test failed: GetVolumeNameForVolumeMountPointA not functioning
> make: *** [file.ok] Error 5
>
> --
> Alexandre Julliard
> [e-mail]

On latest git that test passes for me:

../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p
kernel32_test.exe.so file.c && touch file.ok
file.c:931: Tests skipped: Either no authority to volume, or is
todo_wine for C:\users\dacha\Temp\ err=5 should be 3
file.c:931: Tests skipped: Either no authority to volume, or is
todo_wine for C:\users\dacha\Temp\removeme\ err=5 should be 3
file.c:931: Tests skipped: Either no authority to volume, or is
todo_wine for C:\ err=5 should be 3
file.c:931: Tests skipped: Either no authority to volume, or is
todo_wine for \?\C:\ err=5 should be 3
fixme:ntdll:NtLockFile I/O completion on lock not implemented yet

and I get the same output without my patch.

Damjan Jovanovic