Re: Fix: tab-control flickering

[Vitaliy Margolen]

Saturday, January 28, 2006, 4:21:21 AM, Tobias Loew wrote:
> Changelog:
>     dlls/comctl32/tab.c
> Tobias Loew <[e-mail]>
> Fix: tab-control flickering; tab-control redraws itself after a call to SetCurSel also
>
> when the selection doesn't change
> Tobias Loew
> Index: dlls/comctl32/tab.c
>
> RCS file: /home/wine/wine/dlls/comctl32/tab.c,v
> retrieving revision 1.122
> diff -u -p -r1.122 tab.c
> --- dlls/comctl32/tab.c	8 Nov 2005 12:52:35 -0000	1.122
> +++ dlls/comctl32/tab.c	28 Jan 2006 10:25:40 -0000
> @@ -261,9 +261,11 @@ static inline LRESULT TAB_SetCurSel (TAB
> if (iItem >= 0 && iItem < infoPtr->uNumItem) {
>        prevItem=infoPtr->iSelected;

-      infoPtr->>iSelected=iItem;
> -
>  TAB_EnsureSelectionVisible(infoPtr);
> -
>  TAB_InvalidateTabArea(infoPtr);

+      if (infoPtr->>iSelected != iItem) {
+        infoPtr->>iSelected=iItem;
> -
>    TAB_EnsureSelectionVisible(infoPtr);
> -
>    TAB_InvalidateTabArea(infoPtr);
> -
>  }
> }
>  return prevItem;
>
> }

Please follow the same formatting as the rest of the file/function. In
this case it is 4 spaces indent.

Vitaliy Margolen