Re: user32: stub implementations for WINNLS* functions

[Dmitry Timoshkov]

"Diego 'Flameeyes' PettenР"  wrote:
> diff -Npaur wine-orig/dlls/user/winnls.c wine/dlls/user/winnls.c
> --- wine-orig/dlls/user/winnls.c 1970-01-01 01:00:00.000000000 +0100
> +++ wine/dlls/user/winnls.c 2004-12-24 17:21:24.566402048 +0100

...
> +UINT WINAPI WINNLSGetIMEHotkey(HWND hUnknown1)

...
> +BOOL WINAPI WINNLSEnableIME(HWND hUnknown1, BOOL bUnknown2)

...
> +BOOL WINAPI WINNLSGetEnableStatus(HWND hUnknown1)

Since these APIs are IME related it would be more natural to name
the file ime.c.
> diff -Npaur wine-orig/include/winnls.h wine/include/winnls.h
> --- wine-orig/include/winnls.h 2004-12-24 16:11:18.499482264 +0100
> +++ wine/include/winnls.h 2004-12-24 15:49:59.905643096 +0100
> @@ -757,6 +757,11 @@ BOOL        WINAPI SetThreadLocale(LCID)
>  BOOL        WINAPI SetUserGeoID(GEOID);
>  INT         WINAPI WideCharToMultiByte(UINT,DWORD,LPCWSTR,INT,LPSTR,INT,LPCSTR,LPBOOL);
>
> +UINT        WINAPI WINNLSGetIMEHotkey(HWND);
> +BOOL        WINAPI WINNLSEnableIME(HWND, BOOL);
> +BOOL        WINAPI WINNLSGetEnableStatus(HWND);

Platform SDK has these APIs in winnls32.h file and marks them as old
NT 3.x compatible.

--
Dmitry.

user32: stub implementations for WINNLS* functions

[Diego 'Flameeyes' Pettenò]

On Saturday 25 December 2004 17:20, Dmitry Timoshkov wrote:
> Since these APIs are IME related it would be more natural to name
> the file ime.c.

In fact I was quite unsure how to call the file, and if they should go in an 
already existant one.
> Platform SDK has these APIs in winnls32.h file and marks them as old
> NT 3.x compatible.

Same as above, I wasn't sure if they should have their own file or what :/

I wanted to add these because "Yu-Gi-Oh! Power of Chaos" failed to start 
complaining about WINNLSEnableIME not present in user32.dll .

What's the right way to add these? Adding winnls32.h, and stubs all the 
functions in it, inside a ime.c file?

Thanks,

user32: stub implementations for WINNLS* functions

[Dmitry Timoshkov]

"Diego 'Flameeyes' Pettenò"  wrote:
> I wanted to add these because "Yu-Gi-Oh! Power of Chaos" failed to start
> complaining about WINNLSEnableIME not present in user32.dll .

Does your app uses GetProcAddress to link to that APIs dynamically?
> What's the right way to add these? Adding winnls32.h, and stubs all the
> functions in it, inside a ime.c file?

A common rule is to have exactly the same header structure and dependency
tree as in the microsoft headers.

--
Dmitry.

user32: stub implementations for WINNLS* functions

[Diego 'Flameeyes' Pettenò]

On Sunday 26 December 2004 09:16, Dmitry Timoshkov wrote:
> Does your app uses GetProcAddress to link to that APIs dynamically?

I actually don't know. How can I test this? Enabling trace?
> A common rule is to have exactly the same header structure and dependency
> tree as in the microsoft headers.

Ok I sent a new patch with winnls32.h header, but still only the WINNLS* 
functions, as the other IMEs functions seems to have had the same fate as 
these, I wasn't sure if should be stub-implemented or not.

Regards,

user32: stub implementations for WINNLS* functions

[Dmitry Timoshkov]

"Diego 'Flameeyes' Pettenò"  wrote:
> > Does your app uses GetProcAddress to link to that APIs dynamically?
>
> I actually don't know. How can I test this? Enabling trace?

As almost always with Wine - yes, by examining a relay log.

--
Dmitry.