Re: [PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu

[Nikolay Sivov]

On 24.05.2017 11:21, Hugh McMaster wrote:
> - item.mask = TVIF_CHILDREN | TVIF_HANDLE | TVIF_STATE;
> - item.stateMask = TVIS_EXPANDED | TVIS_EXPANDEDONCE | TVIS_EXPANDPARTIAL;
> - SendMessageW(hwndTV, TVM_GETITEMW, 0, (LPARAM)&item)

Later you only test for TVIS_EXPANDED, is it necessary to request other
bits?

[PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu

[Hugh McMaster]

On Wednesday, 24 May 2017 6:37 PM, Nikolay Sivov wrote:
> On 24.05.2017 11:21, Hugh McMaster wrote:
> > +    item.mask = TVIF_CHILDREN | TVIF_HANDLE | TVIF_STATE;
> > +    item.stateMask = TVIS_EXPANDED | TVIS_EXPANDEDONCE | TVIS_EXPANDPARTIAL;
> > +    SendMessageW(hwndTV, TVM_GETITEMW, 0, (LPARAM)&item)
>
> Later you only test for TVIS_EXPANDED, is it necessary to request other bits?

No, I forgot to remove the other bits after testing. Sorry about that.

I'll send an updated patch.

Thanks for the review.