Re: dbghelp: Implement rudimentary stack walk for ARM64

[Eric Pouech]

> -
>    if ((frame->AddrPC.Mode == AddrModeFlat) &&
> -
>        (frame->AddrFrame.Mode != AddrModeFlat))

this looks strange to me.
I guess, you want to check that both mode address modes are AddrModeFlat
A+

dbghelp: Implement rudimentary stack walk for ARM64

[André Hentschel]

Am 21.01.2013 10:50, schrieb Eric Pouech:
> > -
> >    if ((frame->AddrPC.Mode == AddrModeFlat) &&
> > -
> >        (frame->AddrFrame.Mode != AddrModeFlat))
>
> this looks strange to me.
> I guess, you want to check that both mode address modes are AddrModeFlat
> A+

it's the same as for the other architectures

dbghelp: Implement rudimentary stack walk for ARM64

[Eric Pouech]

Le 21/01/2013 20:26, André Hentschel a écrit :
> Am 21.01.2013 10:50, schrieb Eric Pouech:
> > > -
> > >    if ((frame->AddrPC.Mode == AddrModeFlat) &&
> > > -
> > >        (frame->AddrFrame.Mode != AddrModeFlat))
> >
> > this looks strange to me.
> > I guess, you want to check that both mode address modes are AddrModeFlat
> > A+
>
> it's the same as for the other architectures

do arm, thumb and arm64 have segmented addresses (or real mode addr) ?
A+

dbghelp: Implement rudimentary stack walk for ARM64

[André Hentschel]

Am 22.01.2013 20:26, schrieb Eric Pouech:
> Le 21/01/2013 20:26, André Hentschel a écrit :
> > Am 21.01.2013 10:50, schrieb Eric Pouech:
> > > > -
> > > >    if ((frame->AddrPC.Mode == AddrModeFlat) &&
> > > > -
> > > >        (frame->AddrFrame.Mode != AddrModeFlat))
> > >
> > > this looks strange to me.
> > > I guess, you want to check that both mode address modes are AddrModeFlat
> > > A+
> >
> > it's the same as for the other architectures
>
> do arm, thumb and arm64 have segmented addresses (or real mode addr) ?

good point :)