Re: cabinet: Add breaks to switch statements

[H. Verbeet]

On 13/09/06, Andrew Talbot  wrote:
> Changelog:
>     cabinet: Add breaks to switch statements.
>
> diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c
> --- a/dlls/cabinet/fci.c        2006-09-12 11:55:48.000000000 +0100
> +++ b/dlls/cabinet/fci.c        2006-09-12 23:29:02.000000000 +0100
> @@ -454,11 +454,12 @@
>    switch (cb % 4) {
>      case 3:
>        ul |= (((ULONG)(*pb++)) << 16);
> -
>  break;
> case 2:
>      ul |= (((ULONG)(*pb++)) <<  8);
> -
>  break;
> case 1:
>      ul |= *pb++;
> - default:
>   break;
> }
> csum ^= ul;
>
> diff -urN a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c
> --- a/dlls/cabinet/fdi.c        2006-05-23 13:47:35.000000000 +0100
> +++ b/dlls/cabinet/fdi.c        2006-09-12 23:29:13.000000000 +0100
> @@ -302,9 +302,15 @@
>    }
>
> switch (bytes & 3) {
> - case 3: ul |= *data++ << 16;
> - case 2: ul |= *data++ <<  8;
> - case 1: ul |= *data;
> - case 3:
> -
>  ul |= *data++ << 16;
> -
>  break;
> - case 2:
> -
>  ul |= *data++ <<  8;
> -
>  break;
> - case 1:
> -
>  ul |= *data;
> -
>  break;
> }
>  csum ^= ul;

I think that's supposed to fall through.