Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23920
Your paranoid android.
=== wxppro (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2003std (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== wvistau64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2008s64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7u (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7pro64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w8 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w864 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w1064 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
On 07/02/2016 07:47 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23920
Your paranoid android.
=== wxppro (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2003std (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== wvistau64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2008s64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7u (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7pro64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w8 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w864 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w1064 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
This test is failing when built 32 bits, but I tried building both 64-bit and 32-bit executables using mingw-w64 on my win7 machine, and they both worked. I'm a newbie (this is my first patch), so I'm probably doing something wrong, but I don't know what. The error in question (87) is probably associated with the wrong sizeof() being returned, but I don't know why that would happen.
Thanks, Zeb
On 07/02/2016 10:57 PM, Zebediah Figura wrote:
On 07/02/2016 07:47 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23920
Your paranoid android.
=== wxppro (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2003std (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== wvistau64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2008s64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7u (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7pro64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w8 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w864 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w1064 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
This test is failing when built 32 bits, but I tried building both 64-bit and 32-bit executables using mingw-w64 on my win7 machine, and they both worked. I'm a newbie (this is my first patch), so I'm probably doing something wrong, but I don't know what. The error in question (87) is probably associated with the wrong sizeof() being returned, but I don't know why that would happen.
Thanks, Zeb
Welcome to wine !
Nothing really wrong at a first look but we can nitpick (inconsistent formatting, PFOO usage instead of FOO *, etc.). Returned error may depend on Windows version, installed Service Pack, dll version, structure version... To broaden your tests, you can use the test bot (https://wiki.winehq.org/Wine_TestBot).
In your case, it may be an alignment issue (see http://stackoverflow.com/questions/9049971/windows-etw-starttrace-failing-wi...)
On 07/03/2016 02:38 AM, GOUJON Alexandre wrote:
On 07/02/2016 10:57 PM, Zebediah Figura wrote:
On 07/02/2016 07:47 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23920
Your paranoid android.
=== wxppro (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2003std (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1185: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== wvistau64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w2008s64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7u (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w7pro64 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w8 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w864 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
=== w1064 (32 bit eventlog) === eventlog.c:1172: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1194: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1255: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:1272: Test failed: Expected success eventlog.c:1280: Test failed: Expected ERROR_ALREADY_EXISTS, got 87
This test is failing when built 32 bits, but I tried building both 64-bit and 32-bit executables using mingw-w64 on my win7 machine, and they both worked. I'm a newbie (this is my first patch), so I'm probably doing something wrong, but I don't know what. The error in question (87) is probably associated with the wrong sizeof() being returned, but I don't know why that would happen.
Thanks, Zeb
Welcome to wine !
Nothing really wrong at a first look but we can nitpick (inconsistent formatting, PFOO usage instead of FOO *, etc.). Returned error may depend on Windows version, installed Service Pack, dll version, structure version... To broaden your tests, you can use the test bot (https://wiki.winehq.org/Wine_TestBot).
In your case, it may be an alignment issue (see http://stackoverflow.com/questions/9049971/windows-etw-starttrace-failing-wi...)
I tried fixing the alignment issue by padding, but this raised ERROR_BAD_PATHNAME instead. I can't figure out why. I checked using gdb, and LogFileNameOffset points to a valid pathname, and the other apparent condition (LogFileMode = 0) is not met. I can't figure out why this error is being raised.
-
GOUJON Alexandre -
Marvin -
Zebediah Figura