Re: user32: Fix side effect in SubtractRect()

[Nikolay Sivov]

Hi, Jose.

Please add a test case for this change to user32/tests/uitools.c

user32: Fix side effect in SubtractRect()

[Javier Cantero]

> Hi, Jose.
>
> Please add a test case for this change to user32/tests/uitools.c

OK, but... I don't see any test function for SubtractRect() in
dlls/user32/tests/uitools.c (in fact there is only 1 test case in that
file).

Am I missing something?

user32: Fix side effect in SubtractRect()

[Nikolay Sivov]

On 3/23/2014 00:06, Javier Cantero wrote:
> > Hi, Jose.
> >
> > Please add a test case for this change to user32/tests/uitools.c
>
> OK, but... I don't see any test function for SubtractRect() in
> dlls/user32/tests/uitools.c (in fact there is only 1 test case in that
> file).
>
> Am I missing something?

That means we don't have any tests for it yet, so feel free to add 
test_SubtractRect().
>

user32: Fix side effect in SubtractRect()

[Javier Cantero]

On Sun, Mar 23, 2014 at 12:18:04AM +0400, Nikolay Sivov wrote:
> That means we don't have any tests for it yet, so feel free to add
> test_SubtractRect().

Maybe a better idea is to do two separate patches:
 - First one with some basic conformance test cases for SubtractRect() (create
   the skeleton and verify that the test is well written and working)
 - Then (after the merge of the previous one) another with the fix and the test
   case that covers the fix added to the tests

I can send the first patch tomorrow if there is no objection.