I.e. it's quite a fair play to assume that the user has correctly configured the system to work with his/her locale.
That's exactly my point. If the user didn't correctly configure his/her locale wrt. The iocharset of the drive, then trouble's ahead. So, we can either suggest that it's up to the user to do it correctly (and in that case CP_UNIXCP is just fine for internal handling) ; or we don't (and this was, to my understanding, the need of the codepage option in drive configuration). Basically my question could be rephrased as do we really need this option, or can we remove it. My first (dumb) reaction was if it's in there, it means we need it for some cases. But, I don't want to support this codepage option for no real need, so if no one objects, we could remove it. A+
Pouech Eric DMI AEI CAEN pouech-eric@wanadoo.fr writes:
My first (dumb) reaction was if it's in there, it means we need it for some cases. But, I don't want to support this codepage option for no real need, so if no one objects, we could remove it.
It's here because we didn't have CP_UNIXCP support then. We could definitely remove it.
"Pouech Eric DMI AEI CAEN" pouech-eric@wanadoo.fr wrote:
That's exactly my point. If the user didn't correctly configure his/her locale wrt. The iocharset of the drive, then trouble's ahead. So, we can either suggest that it's up to the user to do it correctly (and in that case CP_UNIXCP is just fine for internal handling) ; or we don't (and this was, to my understanding, the need of the codepage option in drive configuration). Basically my question could be rephrased as do we really need this option, or can we remove it. My first (dumb) reaction was if it's in there, it means we need it for some cases. But, I don't want to support this codepage option for no real need, so if no one objects, we could remove it.
Sure, we could remove it. But do it only after the locale support initialization is moved to ntdll. And yes, CP_UNIXCP support was introduced solely in order to remove hacks such as TextCP in x11drv (has gone already) and codepage parameter in the drive definition.
-
Alexandre Julliard -
Dmitry Timoshkov -
Pouech Eric DMI AEI CAEN