Re: msxml3: Fix crashes on win98

[Paul Vriens]

Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
>     msxml3: Fix crashes on win98
>
> Best Regards
>  Alistair Leslie-Hughes

Just a question. Why not use a goto to a cleanup session instead of having these 
huge indented blocks? Or is goto a bad thing by default?

(I have the same 'issue' with the setupapi/devinst tests. All the tests in there 
have these big sets of indented code. In this setupapi case a simple return on 
failure would have been enough probably)

msxml3: Fix crashes on win98

[Alistair Leslie-Hughes]

> > Just a question. Why not use a goto to a cleanup session instead of having these > huge indented blocks? Or is goto a bad thing by default?

I personally don't use goto statements when an if is good enough, also I find goto's can 
make code harder to read in some instances.  I'm not against goto's, I just don't like them.

Best Regards
 Alistair Leslie-Hughes

_________________________________________________________________
Are you paid what you're worth? Find out: SEEK Salary Centre
http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Fninemsn%2Eseek%2Ecom%2Eau%2F...