Re: [1/2] imagehlp: Add tests for ImageGetDigestStream

[Henri Verbeet]

On 17 July 2010 09:07, Andrey Turkin  wrote:
> +#ifdef NONAMELESSUNION
> +# define U(x)  (x).u
> +#else
> +# define U(x)  (x)
> +#endif

I think this is already done in wine/test.h?
> +static BOOL WINAPI accumulating_stream_output(DIGEST_HANDLE handle, BYTE *pb,
> - DWORD cb)

"pb" can probably be const.

[1/2] imagehlp: Add tests for ImageGetDigestStream

[Andrey Turkin]

On Sunday 18 July 2010 00:26:50 Henri Verbeet wrote:
> On 17 July 2010 09:07, Andrey Turkin  wrote:
> > +#ifdef NONAMELESSUNION
> > +# define U(x)  (x).u
> > +#else
> > +# define U(x)  (x)
> > +#endif
>
> I think this is already done in wine/test.h?

Right. Some other tests define NONAMELESSUNION and just use "u" as union name 
- I'll rewrite this to do the same.
> > +static BOOL WINAPI accumulating_stream_output(DIGEST_HANDLE handle, BYTE
> > *pb, + DWORD cb)
>
> "pb" can probably be const.

No it cannot. accumulating_stream_output is a callback function and its 
signature must be the same as DIGEST_FUNCTION.