I was looking for the place in the source where the ~/.wine directory was defined, and it turns out it's defined twice: once in scheduler/client.c, the other one in server/request.c. There's also some duplicated code: the function get_config_dir is defined in both of these files, and none is static. And both implementation are identical. Is it normal? Do they go in the same executable or in different ones (which ones)? I thought we would rather try to avoid duplication of code, no?
Vincent
On Thu, Apr 18, 2002 at 02:07:25AM -0400, Vincent Béron wrote:
I was looking for the place in the source where the ~/.wine directory was defined, and it turns out it's defined twice: once in scheduler/client.c, the other one in server/request.c. There's also some duplicated code: the function get_config_dir is defined in both of these files, and none is static. And both implementation are identical. Is it normal? Do they go in the same executable or in different ones (which ones)? I thought we would rather try to avoid duplication of code, no?
They go into different binaries, one into the wineserver, one into the wine executable.
Ciao, Marcus
Marcus Meissner a écrit :
On Thu, Apr 18, 2002 at 02:07:25AM -0400, Vincent Béron wrote:
I was looking for the place in the source where the ~/.wine directory was defined, and it turns out it's defined twice: once in scheduler/client.c, the other one in server/request.c. There's also some duplicated code: the function get_config_dir is defined in both of these files, and none is static. And both implementation are identical. Is it normal? Do they go in the same executable or in different ones (which ones)? I thought we would rather try to avoid duplication of code, no?
They go into different binaries, one into the wineserver, one into the wine executable.
Ciao, Marcus
Wouldn't it be possible to separate the common code (a couple #defines, plus get_config_dir) in a shared header?
Vincent
-
Marcus Meissner -
Vincent Béron