Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12332
Your paranoid android.
=== w8 (32 bit ddraw1) === ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/20/15 13:20, Marvin wrote:
=== w8 (32 bit ddraw1) === ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080.
Afaics this is a separate random failure in this test. I have seen it a few times when submitting patches, but I wasn't able to reproduce it when sending a patch through the web interface. I'll look into this bug as well.
Notice that e.g. the follow-up patch doesn't show the issue: http://testbot.winehq.org/JobDetails.pl?Key=12333 .
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-03-20 um 13:20 schrieb Marvin:
ddraw1.c:6302: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6306: Test failed: Got unexpected color 0x00000080.
It seems that the attached patch fixes the problem. I've run it through the testbot 5 times and this kind of failure was reliably gone with it.
-
Marvin -
Stefan Dösinger