Hi Alistair,
On 03/14/12 10:00, Alistair Leslie-Hughes wrote:
--- a/dlls/jscript/jsutils.c +++ b/dlls/jscript/jsutils.c @@ -187,11 +187,14 @@ HRESULT to_primitive(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret case VT_EMPTY: case VT_NULL: case VT_BOOL:
- case VT_I2:
First of all, this is not a patch against current Git.
You're changing core parts of jscript and I'd really like an evidence that it's done in the right direction. There are many parts of code that assume given types are returned as result, so I'm really picky about getting this right. In your previous test you had getVT that was hiding the difference between VT_I4 and VT_I2. I've asked you about better test and now you've removed tests that were using getVT at all and took my guesses as assumptions for implementation. Please add proper tests that really show your implementing things really the right way. Hint: it may be easier to concentrate one one aspect, say to_number which is easy to test, first. That patch may be well split.
Cheers, Jacek
-
Jacek Caban