Re: configure: add --with-fontfir (try3) with patch!

[Vitaly Lipatov]

On Tuesday 21 February 2006 20:10, Vitaly Lipatov wrote:
> I made some fixes to correct work.
>
> Changelog
> add --with-fontdir parameter to configure for set WINE fonts
> placement.

Sorry, what is broken with my patch?
http://www.winehq.org/pipermail/wine-patches/2006-February/024535.html

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

Vitaly Lipatov  writes:
> On Tuesday 21 February 2006 20:10, Vitaly Lipatov wrote:
> > I made some fixes to correct work.
> >
> > Changelog
> > add --with-fontdir parameter to configure for set WINE fonts
> > placement.
>
> Sorry, what is broken with my patch?
> http://www.winehq.org/pipermail/wine-patches/2006-February/024535.html

Can't you achieve the same thing with the standard configure options?
What are you trying to do with the fonts?

configure: add --with-fontfir (try3) with patch!

[Vitaly Lipatov]

On Sunday 05 March 2006 20:43, Alexandre Julliard wrote:
> Vitaly Lipatov  writes:
> > On Tuesday 21 February 2006 20:10, Vitaly Lipatov wrote:
> > > I made some fixes to correct work.
> > >
> > > Changelog
> > > add --with-fontdir parameter to configure for set WINE
> > > fonts placement.

...
> Can't you achieve the same thing with the standard configure
> options? What are you trying to do with the fonts?

I wish remove direct path to font dir from fonts/Makefile.am and 
make in configurable via configure option.
I can't place fonts in datadir/wine/fonts now.

P.S.
I have plans to use @FONTDIR@ in other Makefiles.

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

Vitaly Lipatov  writes:
> > Can't you achieve the same thing with the standard configure
> > options? What are you trying to do with the fonts?
>
> I wish remove direct path to font dir from fonts/Makefile.am and 
> make in configurable via configure option.
> I can't place fonts in datadir/wine/fonts now.
>
> P.S.
> I have plans to use @FONTDIR@ in other Makefiles.

Could you please explain what you are trying to do?  I don't think we
want to hardcode more paths, I've just been getting rid of them.

configure: add --with-fontfir (try3) with patch!

[Vitaly Lipatov]

On Sunday 05 March 2006 23:22, Alexandre Julliard wrote:
> Could you please explain what you are trying to do?  I don't
> think we want to hardcode more paths, I've just been getting
> rid of them.

I told about
fontdir   = $(datadir)/fonts/wine
line in fonts/Makefile.in. It is _hardcoded_ path. I try to get 
rid of this and get possibility to set path to fontdir with 
configure options.

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

Vitaly Lipatov  writes:
> On Sunday 05 March 2006 23:22, Alexandre Julliard wrote:
> > Could you please explain what you are trying to do?  I don't
> > think we want to hardcode more paths, I've just been getting
> > rid of them.
>
> I told about
> fontdir   = $(datadir)/fonts/wine
> line in fonts/Makefile.in. It is _hardcoded_ path. I try to get 
> rid of this and get possibility to set path to fontdir with 
> configure options.

It's not less hardcoded if it's in configure... You still haven't
explained what you are trying to do, and why you can't put fonts in
datadir.

configure: add --with-fontfir (try3) with patch!

[Vitaly Lipatov]

On Monday 06 March 2006 00:43, Alexandre Julliard wrote:
> Vitaly Lipatov  writes:
> > On Sunday 05 March 2006 23:22, Alexandre Julliard wrote:
> > > Could you please explain what you are trying to do?  I
> > > don't think we want to hardcode more paths, I've just been
> > > getting rid of them.
> >
> > I told about
> > fontdir   = $(datadir)/fonts/wine
> > line in fonts/Makefile.in. It is _hardcoded_ path. I try to
> > get rid of this and get possibility to set path to fontdir
> > with configure options.
>
> It's not less hardcoded if it's in configure... You still

I planned place _default_ path to configure. With --with-fontdir 
option we can set it to any other place.
If we have this path hardcoded in fonts/Makefile.in we can't use 
it from other places of WINE tree.
> haven't explained what you are trying to do, and why you can't
> put fonts in datadir.

I don't like WINE fonts in %_datadir/fonts/wine, I it crossed 
with ALT Linux font policy and so on.
I have a small patch to check the font dir after C:
\WINDOWS\FONTS for bitmap/ttf fonts. It patch needs in 
@FONTDIR@ substitution in Makefile.
Sorry if I can't express my thoughts in English clearly.

configure: add --with-fontfir (try3) with patch!

[StartCom Ltd.]

I would like to through in my support for Vitaly on this issue (and
maybe similar ones) which happen to be the source of some discussions
lately (rpath was one, I think).

More configuration options makes wine to be more easy configured, build
and adjusted, making it more scalable....Distribution based patches
should be the last resort - not the first. If a configure option, such
as in this case can be so easily implemented, it should supported...As
long as it hard coded during make, than there should be a configuration
option for this (font path) but also others....

Regards

Signer:      Eddy Nigg
Company: StartCom Linux at www.startcom.org http://www.startcom.org/
                MediaHost™ at www.mediahost.org http://www.mediahost.org/
                StartCom Certification Authority at cert.startcom.org
http://cert.startcom.org/
Skype:      startcom callto://startcom/
Phone:      [phone]

Vitaly Lipatov wrote:
> On Monday 06 March 2006 00:43, Alexandre Julliard wrote:
> > Vitaly Lipatov  writes:
> > > On Sunday 05 March 2006 23:22, Alexandre Julliard wrote:
> > > > Could you please explain what you are trying to do?  I
> > > > don't think we want to hardcode more paths, I've just been
> > > > getting rid of them.
> > >
> > > I told about
> > > fontdir   = $(datadir)/fonts/wine
> > > line in fonts/Makefile.in. It is _hardcoded_ path. I try to
> > > get rid of this and get possibility to set path to fontdir
> > > with configure options.
> >
> > It's not less hardcoded if it's in configure... You still
>
> I planned place _default_ path to configure. With --with-fontdir 
> option we can set it to any other place.
> If we have this path hardcoded in fonts/Makefile.in we can't use 
> it from other places of WINE tree.
> > haven't explained what you are trying to do, and why you can't
> > put fonts in datadir.
>
> I don't like WINE fonts in %_datadir/fonts/wine, I it crossed 
> with ALT Linux font policy and so on.
> I have a small patch to check the font dir after C:
> \WINDOWS\FONTS for bitmap/ttf fonts. It patch needs in 
> @FONTDIR@ substitution in Makefile.
> Sorry if I can't express my thoughts in English clearly.

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

"StartCom Ltd."  writes:
> I would like to through in my support for Vitaly on this issue (and
> maybe similar ones) which happen to be the source of some discussions
> lately (rpath was one, I think).
>
> More configuration options makes wine to be more easy configured, build
> and adjusted, making it more scalable....Distribution based patches
> should be the last resort - not the first. If a configure option, such
> as in this case can be so easily implemented, it should supported...As
> long as it hard coded during make, than there should be a configuration
> option for this (font path) but also others....

The problem with adding an option for every single thing that someone
might want to change is that you end up with a million of them,
burying the few important options in a mass of useless details.

So for things that are only used to build some special package, it's
perfectly reasonable IMO to ask the packager to pass options to make
instead of configure, since it's all done from a script anyway.

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

Vitaly Lipatov  writes:
> I don't like WINE fonts in %_datadir/fonts/wine, I it crossed 
> with ALT Linux font policy and so on.

Where do you install them then?

configure: add --with-fontfir (try3) with patch!

[Vitaly Lipatov]

В сообщении от 6 марта 2006 14:18 Alexandre Julliard написал(a):
> Vitaly Lipatov  writes:
> > I don't like WINE fonts in %_datadir/fonts/wine, I it crossed
> > with ALT Linux font policy and so on.
>
> Where do you install them then?

%_datadir/wine/fonts
%_datadir/fonts is default fontconfig's path for font search.

configure: add --with-fontfir (try3) with patch!

[Alexandre Julliard]

Vitaly Lipatov  writes:
> В сообщении от 6 марта 2006 14:18 Alexandre Julliard написал(a):
> > Vitaly Lipatov  writes:
> > > I don't like WINE fonts in %_datadir/fonts/wine, I it crossed
> > > with ALT Linux font policy and so on.
> >
> > Where do you install them then?
>
> %_datadir/wine/fonts
> %_datadir/fonts is default fontconfig's path for font search.

Well yes, that was the idea, that they should be found by
fontconfig. Now of course if we make the code look in that path
explicitly then I agree we might as well put them in datadir/wine.