Re: [resend] advapi32: Implement CredReadDomainCredentials stub

[James Hawkins]

On Tue, Oct 7, 2008 at 11:17 AM, Andrey Turkin  wrote:
> [wasn't submitted nor rejected, so resending]
>
> Added CredReadDomainCredentialsA and CredReadDomainCredentialsW stub implementations.
> Required for MSN Messenger 7.0 to start in WinXP mode
>
> dlls/advapi32/advapi32.spec |    4 +-
>  dlls/advapi32/cred.c        |  142 +++++++++++++++++++++++++++++++++++++++++++
>  include/wincred.h           |   39 ++++++++++++
>  3 files changed, 183 insertions(+), 2 deletions(-)

+    if (TargetInformation->NetbiosServerName) len += sizeof(WCHAR) *
MultiByteToWideChar(CP_ACP, 0, TargetInformation->NetbiosServerName,
-1, NULL, 0);

That is a seriously long line.  Please try to keep line lengths close
to 80 cols.

+    if (!TargetInformation || !Size || !Credentials ||

+          !(TargetInformation->NetbiosServerName ||
TargetInformation->DnsServerName ||
TargetInformation->NetbiosDomainName

+         || TargetInformation->DnsDomainName ||TargetInformation->DnsTreeName))

+    {

+        SetLastError(ERROR_INVALID_PARAMETER);

+        return FALSE;

+    }

I don't think you should make such an implementation without at least
some simple tests.