On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote:
Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer:
Is there anything I can do to move this patch forward? I've fixed all
the
issues that have been raised so far. I have no dea what it is waiting
on,
and if there is anything I can do to get it committed or if it is just a question of being patient. As I said previously I'd happily write a test for it, but I couldn't find any examples of how to test a modal dialog
box
in Wine, so I just don't know what the right way to do that is.
According to http://source.winehq.org/patches/ the patch is pending. You may have more luck if you send some test cases for the unit tests first.
Which, as I tried to explain in my mail, I have no idea how to do because
the function is basically (from user-space) atomic and implements a Modal dialog box, and I haven't seen any Wine tests that deal with anything remotely like that. So I am at a loss as to how to write tests for this function. If that is what is needed to get it committed, then I need guidance as to how to go about it.
On 30 January 2010 16:44, Geoffrey Hausheer winedevel9605@phracturedblue.com wrote:
On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote:
Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer:
Is there anything I can do to move this patch forward? I've fixed all the issues that have been raised so far. I have no dea what it is waiting on, and if there is anything I can do to get it committed or if it is just a question of being patient. As I said previously I'd happily write a test for it, but I couldn't find any examples of how to test a modal dialog box in Wine, so I just don't know what the right way to do that is.
According to http://source.winehq.org/patches/ the patch is pending. You may have more luck if you send some test cases for the unit tests first.
Which, as I tried to explain in my mail, I have no idea how to do because the function is basically (from user-space) atomic and implements a Modal dialog box, and I haven't seen any Wine tests that deal with anything remotely like that. So I am at a loss as to how to write tests for this function. If that is what is needed to get it committed, then I need guidance as to how to go about it.
You can create tests that are marked as winetest_interactive: if ( ! winetest_interactive ) { skip("these tests require user interaction to work."); return }
This is used in several places in the tests (e.g. dinput/tests/joystick.c) to provide visual/interactive checks for functionality that cannot otherwise be tested.
Alternatively, does the API provide a way to hook into the modal dialog, like comdlg32 does? If so, you could use that to drive the tests.
- Reece
-
Geoffrey Hausheer -
Reece Dunn