Re: [PATCH v2 3/6] ddraw: Forbid creating flippable cubemaps.

[Henri Verbeet]

On 13 May 2016 at 13:55, Józef Kucia  wrote:
> -
>    if (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP)
> -
>    {
> -
>        WARN("Tried to create a flippable cubemap.\n");
> -
>        HeapFree(GetProcessHeap(), 0, texture);
> -
>        return DDERR_INVALIDPARAMS;
> -
>    }
> -
>    if (desc->ddsCaps.dwCaps & DDSCAPS_TEXTURE)
>    {
>        FIXME("Flippable textures not implemented.\n");
>
> @@ -5748,6 +5755,8 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_
>          {
>              WARN("Tried to specify a back buffer count for a non-flippable surface.\n");
>              HeapFree(GetProcessHeap(), 0, texture);
> -
>        if (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP)
> -
>            return DDERR_INVALIDPARAMS;
>        return DDERR_INVALIDCAPS;
>    }

I suppose it ends up being more or less the same thing, but to me this
looks like DDSD_BACKBUFFERCOUNT being disallowed for cubemaps rather
than DDSCAPS_FLIP.