Re: advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Hans Leidekker]

On Thursday 14 September 2006 11:13, Kai Blin wrote:
> MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

Tell Microsoft about it ;-) Your patch breaks the md5 test on Windows
because it depends on the struct layout:

crypt_md5.c:90: Test failed: invalid initialization
crypt_md5.c:93: Test failed: update doesn't work correctly
crypt_md5.c:96: Test failed: update doesn't work correctly
crypt_md5: 5 tests executed, 0 marked as todo, 3 failures.

-Hans

advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Kai Blin]

On Thursday 14 September 2006 13:33, Hans Leidekker wrote:
> On Thursday 14 September 2006 11:13, Kai Blin wrote:
> > MD4_CTX and MD5_CTX have the same elements, declare them in the same
> > order.
>
> Tell Microsoft about it ;-) Your patch breaks the md5 test on Windows
> because it depends on the struct layout:
>
> crypt_md5.c:90: Test failed: invalid initialization
> crypt_md5.c:93: Test failed: update doesn't work correctly
> crypt_md5.c:96: Test failed: update doesn't work correctly
> crypt_md5: 5 tests executed, 0 marked as todo, 3 failures.

What windows version is that? I checked on Win2k and the tests wouldn't 
execute. tests.winehq.org/data/ doesn't show them running either.

Oh well, more code duplication then, sorry about the useless patch then.

Kai

advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Hans Leidekker]

On Thursday 14 September 2006 20:57, Kai Blin wrote:
> What windows version is that? I checked on Win2k and the tests wouldn't
> execute. tests.winehq.org/data/ doesn't show them running either.

I tested on WinXP. Did you get any error message?

-Hans

advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Kai Blin]

On Friday 15 September 2006 09:16, Hans Leidekker wrote:
> On Thursday 14 September 2006 20:57, Kai Blin wrote:
> > What windows version is that? I checked on Win2k and the tests wouldn't
> > execute. tests.winehq.org/data/ doesn't show them running either.
>
> I tested on WinXP. Did you get any error message?

No, the tests simply got out on the

if(!pMD5Init || ! pMD5Update || !pMD5Final) goto out;

line. Maybe the advapi MD5 stuff is an XP thing then.

Kai

advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Paul Vriens]

On Fri, 2006-09-15 at 13:25 +0200, Kai Blin wrote:
> On Friday 15 September 2006 09:16, Hans Leidekker wrote:
> > On Thursday 14 September 2006 20:57, Kai Blin wrote:
> > > What windows version is that? I checked on Win2k and the tests wouldn't
> > > execute. tests.winehq.org/data/ doesn't show them running either.
> >
> > I tested on WinXP. Did you get any error message?
>
> No, the tests simply got out on the
>
> if(!pMD5Init || ! pMD5Update || !pMD5Final) goto out;
>
> line. Maybe the advapi MD5 stuff is an XP thing then.
>
> Kai

The tests run as of XP (so XP and W2K3, Vista?)

Cheers,

Paul.

advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.

[Kai Blin]

On Friday 15 September 2006 14:01, Paul Vriens wrote:
> The tests run as of XP (so XP and W2K3, Vista?)

Ah, good to know, thanks.

Kai