Re: [PATCH 2/5] wined3d: Recreate DIB sections in wined3d_surface_update_desc().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-12-11 14:32, schrieb Henri Verbeet:
> Since commit 6bc69c271bf440b4ecad012dc57888fdffc075d5, the GDI
> implementation assumes DIB sections always exist.

Actually the idea behind this patch was that all paths that need a DIB
section create one if necessary. Is there a place where that's not
true? If it's about x11_copy_to_screen I think the better fix is
calling surface_getdc from there.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSqHuLAAoJEN0/YqbEcdMwreEP/RCg6dr20bqTzc+P3HB+mvIO
JCURzQz25PzWTnIn4+M3f8a/NcHP0Fu6621Te71Y2kk+be1ncIDMI9SAEAOzP4cW
ELwmSlxgDUgZIx8w+cR8ce56Jg+ESesNEfPqwT7oWSVHnJqZnouo8IBp8xXCHc3K
J+ACLw8PWZoorXg9YVVLrVWwEyxr1mamQE/35WlXEMRJ/6gqZwdML6bCY/wVJ/Vf
18lBebBy9aluiXKyuEUQA1rz1n4Ji7Cz6IFiK+TGGkiPk9WHJekG3tREI9LoT4Hi
VFrktfl/3P1wNb4/ab2U0xjbVOPdtqHqSU6RWfB+jjI3VvzLjjtinI/5I5ip2f8u
f7XFm8EV2+0czBjXwgaIouWYYEKIEE1wZKZBPjUU+RQUKfdohuSD/QCNC9E3uf7f
qhR01J3M4O6z41RJGwBMBwI2lHsEQWZaj3rsryJzo2mxRoMvv/ksV7oB75mgPQaz
jShTnEvs4SMFh9PMkANNpRVUWvVu0b27hUeIvlo2GbNDhJKsnll0YFQfL6eKm29y
Kr7ltkqRoWyeA/2Q3IGBTFF0l1a1F9JAgZxy8SRqpykglfc0ekCazGhQUku0Vi1/
1lvnzf2K9RkT5gIPlMmxuHTmEunc4wdk2T7SsEZK8htnMTqIyV+XoaSyjezg1K2R
uDCAYLqI+6lx9j5r31xR
=tLfE
-----END PGP SIGNATURE-----

[PATCH 2/5] wined3d: Recreate DIB sections in wined3d_surface_update_desc().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-12-11 15:49, schrieb Stefan Dösinger:
> Actually the idea behind this patch was that all paths that need a
> DIB section create one if necessary. Is there a place where that's
> not true? If it's about x11_copy_to_screen I think the better fix
> is calling surface_getdc from there.

Actually, that would be inefficient due to SFLAG_PIN_SYSMEM, so your
patch makes perfect sense. Still I'm curious what the exact problem is.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSqH1tAAoJEN0/YqbEcdMw44UP/2oGsK0XFqzWWxAnZJ1T6JMF
zn3m6nR+aAOzuCY980zPdltKhIoKIECIWE3myXE2xKzqsRsmPWMKi4dk0nr3CCpa
XNbBERu4Tk+LNUQU7ugrUYnW3r2ihrFRup/z+rjViWGXrhhHVWTFSe2ieE7aJphF
xG6D8adN9hrzMm+Pm+7PI8adwHWMWe8C4+zAyafVo5oXb8U4D8HhjtmERT+5fgf+
fhyZ7f5WAzcwvdjykcDonTm0SyNUVrT/v5Yfsx4qG6jQwpN4wlJpOzB1+cGA6wlL
sXoS6UwkpSkp4b9LUPlsvJgcQC2JII1hJbycjBg/hw+MEgjOdKyWfNRb94k9MGMo
ZHLk71iYI0PDLPRV+D9/Ql56hLmaa+sTX+HXiTQimVbIxg+40a4qjQVUNyfIxkYz
iH+qysMx/hmcyU4kWGi4hdbq0sYtKPih35KKUSh7uREXXC6m1W50sFlj3Y0WH+Oo
yE7v1IjBKWG2IHAYLYwcNy4zS8AnlHRXZjbe5YScQXU/v0A/RAOvSzLUZzMLxMxV
xzPfXfQ9lrpPXdGl4OxKSVHjQNLNe+nWAgPc4+TObA67LA6QrXmryKr1nKNr/vHf
qvr99XawTQ2xkLrIVNXxLhc16zb9Qy7TPaDszJEUzykLqE6hrIkTfznHF+BDB4iB
FMw9nKzcyQcGfoGcYchG
=g2jP
-----END PGP SIGNATURE-----

[PATCH 2/5] wined3d: Recreate DIB sections in wined3d_surface_update_desc().

[Henri Verbeet]

On 11 December 2013 15:57, Stefan Dösinger  wrote:
> Am 2013-12-11 15:49, schrieb Stefan Dösinger:
> > Actually the idea behind this patch was that all paths that need a
> > DIB section create one if necessary. Is there a place where that's
> > not true? If it's about x11_copy_to_screen I think the better fix
> > is calling surface_getdc from there.
>
> Actually, that would be inefficient due to SFLAG_PIN_SYSMEM, so your
> patch makes perfect sense. Still I'm curious what the exact problem is.

Yes, it's x11_copy_to_screen() in particular that triggered this,
although it may not be the only place.