I have a small question:
I find some function LONG WINAPI AVIStreamSampleToTime(PAVISTREAM pstream, LONG lSample) (in the avifil32 dll), the second parameter should really be an ULONG instead of a LONG. It'd fix the signedness problems.
My question is, is such a change allowed? And what should I do to update for such a change (except for the header gcc warns about)
In case such change must not be performed, I'll just add a local variable which is a casted version. I thought this needs asking; adding in unnecessary variables doesn't seem the best fix to me.
regards,
Joris
____________________________________________________________________________________ Don't pick lemons. See all the new 2007 cars at Yahoo! Autos. http://autos.yahoo.com/new_cars.html
Joris Huizer wrote:
I have a small question:
I find some function LONG WINAPI AVIStreamSampleToTime(PAVISTREAM pstream, LONG lSample) (in the avifil32 dll), the second parameter should really be an ULONG instead of a LONG. It'd fix the signedness problems.
My question is, is such a change allowed?
If it is a official WinAPI you have to conform to what Windows has there. If it is an internal function you can change it.
And what should I do to update for such a change (except for the header gcc warns about)
In case such change must not be performed, I'll just add a local variable which is a casted version. I thought this needs asking; adding in unnecessary variables doesn't seem the best fix to me.
bye michael
On Sat, 10 Feb 2007, Joris Huizer wrote:
I find some function LONG WINAPI AVIStreamSampleToTime(PAVISTREAM pstream, LONG lSample) (in the avifil32 dll), the second parameter should really be an ULONG instead of a LONG. It'd fix the signedness problems.
My question is, is such a change allowed?
No. Our headers must match the PSDK ones otherwise it would cause trouble for people trying to recompile Windows code with them. Since the PSDK says the second parameter is a LONG, that's what we have to use too.
-
Francois Gouget -
Joris Huizer -
Michael Stefaniuc