Signed-off-by: Esme Povirk esme@codeweavers.com --- dlls/diasymreader/Makefile.in | 2 +- dlls/diasymreader/writer.c | 64 +++++++++++++++++++++++++++++++++-- 2 files changed, 63 insertions(+), 3 deletions(-)
diff --git a/dlls/diasymreader/Makefile.in b/dlls/diasymreader/Makefile.in index e9d6fee09e8..34e1286a496 100644 --- a/dlls/diasymreader/Makefile.in +++ b/dlls/diasymreader/Makefile.in @@ -1,5 +1,5 @@ MODULE = diasymreader.dll -IMPORTS = uuid +IMPORTS = uuid rpcrt4
EXTRADLLFLAGS = -Wb,--prefer-native
diff --git a/dlls/diasymreader/writer.c b/dlls/diasymreader/writer.c index 7970fbaca9a..638c3adec51 100644 --- a/dlls/diasymreader/writer.c +++ b/dlls/diasymreader/writer.c @@ -23,7 +23,9 @@ #include "windef.h" #include "winbase.h" #include "objbase.h" +#include "rpc.h"
+#include "wine/mscvpdb.h" #include "wine/debug.h" #include "wine/heap.h"
@@ -34,6 +36,10 @@ WINE_DEFAULT_DEBUG_CHANNEL(diasymreader); typedef struct SymWriter { ISymUnmanagedWriter5 iface; LONG ref; + CRITICAL_SECTION lock; + GUID pdb_guid; + DWORD pdb_age; + WCHAR pdb_filename[MAX_PATH]; } SymWriter;
static inline SymWriter *impl_from_ISymUnmanagedWriter5(ISymUnmanagedWriter5 *iface) @@ -87,6 +93,8 @@ static ULONG WINAPI SymWriter_Release(ISymUnmanagedWriter5 *iface)
if (ref == 0) { + This->lock.DebugInfo->Spare[0] = 0; + DeleteCriticalSection(&This->lock); heap_free(This); }
@@ -213,15 +221,62 @@ static HRESULT WINAPI SymWriter_SetMethodSourceRange(ISymUnmanagedWriter5 *iface static HRESULT WINAPI SymWriter_Initialize(ISymUnmanagedWriter5 *iface, IUnknown *emitter, const WCHAR *filename, IStream *pIStream, BOOL fFullBuild) { + SymWriter *This = impl_from_ISymUnmanagedWriter5(iface); + FIXME("(%p,%p,%s,%p,%u)\n", iface, emitter, debugstr_w(filename), pIStream, fFullBuild); + + EnterCriticalSection(&This->lock); + + if (filename) + wcsncpy_s(This->pdb_filename, MAX_PATH, filename, _TRUNCATE); + + LeaveCriticalSection(&This->lock); + return S_OK; }
static HRESULT WINAPI SymWriter_GetDebugInfo(ISymUnmanagedWriter5 *iface, IMAGE_DEBUG_DIRECTORY *pIDD, DWORD cData, DWORD *pcData, BYTE data[]) { - FIXME("(%p,%p,%lu,%p,%p)\n", iface, pIDD, cData, pcData, data); - return E_NOTIMPL; + SymWriter *This = impl_from_ISymUnmanagedWriter5(iface); + DWORD name_length, data_size; + OMFSignatureRSDS *rsds_data = (OMFSignatureRSDS*)data; + + TRACE("(%p,%p,%lu,%p,%p)\n", iface, pIDD, cData, pcData, data); + + EnterCriticalSection(&This->lock); + + name_length = WideCharToMultiByte(CP_UTF8, 0, This->pdb_filename, -1, NULL, 0, NULL, NULL); + data_size = FIELD_OFFSET(OMFSignatureRSDS, name) + name_length; + if (pcData) + *pcData = data_size; + + if (pIDD) + { + pIDD->Characteristics = 0; + pIDD->MajorVersion = 0; + pIDD->MinorVersion = 0; + pIDD->Type = IMAGE_DEBUG_TYPE_CODEVIEW; + pIDD->SizeOfData = data_size; + } + + if (data) + { + if (data_size > cData) + { + LeaveCriticalSection(&This->lock); + return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER); + } + + memcpy(rsds_data->Signature, "RSDS", 4); + rsds_data->guid = This->pdb_guid; + rsds_data->age = This->pdb_age; + WideCharToMultiByte(CP_UTF8, 0, This->pdb_filename, -1, rsds_data->name, name_length, NULL, NULL); + } + + LeaveCriticalSection(&This->lock); + + return S_OK; }
static HRESULT WINAPI SymWriter_DefineSequencePoints(ISymUnmanagedWriter5 *iface, ISymUnmanagedDocumentWriter *document, @@ -367,6 +422,11 @@ HRESULT SymWriter_CreateInstance(REFIID iid, void **ppv)
This->iface.lpVtbl = &SymWriter_Vtbl; This->ref = 1; + InitializeCriticalSection(&This->lock); + This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": SymWriter.lock"); + UuidCreate(&This->pdb_guid); + This->pdb_age = 1; + This->pdb_filename[0] = 0;
hr = IUnknown_QueryInterface(&This->iface, iid, ppv);
Signed-off-by: Esme Povirk esme@codeweavers.com --- dlls/diasymreader/Makefile.in | 2 + dlls/diasymreader/diasymreader.idl | 40 ++++++++++++++ dlls/diasymreader/diasymreader_private.h | 1 + dlls/diasymreader/writer.c | 70 ++++++++++++++++++++++++ 4 files changed, 113 insertions(+) create mode 100644 dlls/diasymreader/diasymreader.idl
diff --git a/dlls/diasymreader/Makefile.in b/dlls/diasymreader/Makefile.in index 34e1286a496..545368d5c11 100644 --- a/dlls/diasymreader/Makefile.in +++ b/dlls/diasymreader/Makefile.in @@ -7,4 +7,6 @@ C_SRCS = \ main.c \ writer.c
+IDL_SRCS = diasymreader.idl + RC_SRCS = diasymreader.rc diff --git a/dlls/diasymreader/diasymreader.idl b/dlls/diasymreader/diasymreader.idl new file mode 100644 index 00000000000..8b50ad0ceab --- /dev/null +++ b/dlls/diasymreader/diasymreader.idl @@ -0,0 +1,40 @@ +/* + * Copyright (C) 2022 Esme Povirk + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +import "unknwn.idl"; +import "objidl.idl"; +import "oaidl.idl"; + +#pragma makedep header + +/* Undocumented interface used by + * https://github.com/dotnet/symreader/blob/fe43beb65a8567834c717e2478ba36f1e98... */ +[ + object, + uuid(98ecee1e-752d-11d3-8d56-00c04f680b2b), + pointer_default(unique) +] +interface IPdbWriter : IUnknown +{ + HRESULT SetPath([in] const WCHAR *fullpath, [in] IStream *stream, [in] BOOL fullbuild); + HRESULT OpenMod([in] const WCHAR *modulename, [in] const WCHAR *filename); + HRESULT CloseMod(); + HRESULT GetPath([in] DWORD ccData, [out] DWORD *pccData, [out, size_is(ccData), length_is(*pccData)] WCHAR *path); + HRESULT GetSignatureAge([out] DWORD *timestamp, [out] DWORD *age); +} + diff --git a/dlls/diasymreader/diasymreader_private.h b/dlls/diasymreader/diasymreader_private.h index 4275193e3d4..2d05859d447 100644 --- a/dlls/diasymreader/diasymreader_private.h +++ b/dlls/diasymreader/diasymreader_private.h @@ -19,5 +19,6 @@ #include "corhdr.h" #include "cordebug.h" #include "corsym.h" +#include "diasymreader.h"
HRESULT SymWriter_CreateInstance(REFIID iid, void **ppv) DECLSPEC_HIDDEN; diff --git a/dlls/diasymreader/writer.c b/dlls/diasymreader/writer.c index 638c3adec51..a675d79ccf9 100644 --- a/dlls/diasymreader/writer.c +++ b/dlls/diasymreader/writer.c @@ -35,6 +35,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(diasymreader);
typedef struct SymWriter { ISymUnmanagedWriter5 iface; + IPdbWriter IPdbWriter_iface; LONG ref; CRITICAL_SECTION lock; GUID pdb_guid; @@ -47,6 +48,11 @@ static inline SymWriter *impl_from_ISymUnmanagedWriter5(ISymUnmanagedWriter5 *if return CONTAINING_RECORD(iface, SymWriter, iface); }
+static inline SymWriter *impl_from_IPdbWriter(IPdbWriter *iface) +{ + return CONTAINING_RECORD(iface, SymWriter, IPdbWriter_iface); +} + static HRESULT WINAPI SymWriter_QueryInterface(ISymUnmanagedWriter5 *iface, REFIID iid, void **ppv) { @@ -63,6 +69,10 @@ static HRESULT WINAPI SymWriter_QueryInterface(ISymUnmanagedWriter5 *iface, REFI { *ppv = &This->iface; } + else if (IsEqualIID(&IID_IPdbWriter, iid)) + { + *ppv = &This->IPdbWriter_iface; + } else { WARN("unknown interface %s\n", debugstr_guid(iid)); @@ -411,6 +421,65 @@ static const ISymUnmanagedWriter5Vtbl SymWriter_Vtbl = { SymWriter_MapTokenToSourceSpan };
+static HRESULT WINAPI SymWriter_PdbWriter_QueryInterface(IPdbWriter *iface, REFIID iid, void **ppv) +{ + SymWriter *This = impl_from_IPdbWriter(iface); + return ISymUnmanagedWriter5_QueryInterface(&This->iface, iid, ppv); +} + +static ULONG WINAPI SymWriter_PdbWriter_AddRef(IPdbWriter *iface) +{ + SymWriter *This = impl_from_IPdbWriter(iface); + return ISymUnmanagedWriter5_AddRef(&This->iface); +} + +static ULONG WINAPI SymWriter_PdbWriter_Release(IPdbWriter *iface) +{ + SymWriter *This = impl_from_IPdbWriter(iface); + return ISymUnmanagedWriter5_Release(&This->iface); +} + +static HRESULT WINAPI SymWriter_SetPath(IPdbWriter *iface, const WCHAR *fullpath, IStream *stream, BOOL fullbuild) +{ + FIXME("(%p,%s,%p,%u)\n", iface, debugstr_w(fullpath), stream, fullbuild); + return E_NOTIMPL; +} + +static HRESULT WINAPI SymWriter_OpenMod(IPdbWriter *iface, const WCHAR *modulename, const WCHAR *fullpath) +{ + FIXME("(%p,%s,%s)\n", iface, debugstr_w(modulename), debugstr_w(fullpath)); + return E_NOTIMPL; +} + +static HRESULT WINAPI SymWriter_CloseMod(IPdbWriter *iface) +{ + FIXME("(%p)\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI SymWriter_GetPath(IPdbWriter *iface, DWORD ccData, DWORD *pccData, WCHAR *path) +{ + FIXME("(%p,%u,%p,%p)\n", iface, ccData, pccData, path); + return E_NOTIMPL; +} + +static HRESULT WINAPI SymWriter_GetSignatureAge(IPdbWriter *iface, DWORD *timestamp, DWORD *age) +{ + FIXME("(%p,%p,%p)\n", iface, timestamp, age); + return E_NOTIMPL; +} + +static const IPdbWriterVtbl SymWriter_PdbWriter_Vtbl = { + SymWriter_PdbWriter_QueryInterface, + SymWriter_PdbWriter_AddRef, + SymWriter_PdbWriter_Release, + SymWriter_SetPath, + SymWriter_OpenMod, + SymWriter_CloseMod, + SymWriter_GetPath, + SymWriter_GetSignatureAge +}; + HRESULT SymWriter_CreateInstance(REFIID iid, void **ppv) { SymWriter *This; @@ -421,6 +490,7 @@ HRESULT SymWriter_CreateInstance(REFIID iid, void **ppv) return E_OUTOFMEMORY;
This->iface.lpVtbl = &SymWriter_Vtbl; + This->IPdbWriter_iface.lpVtbl = &SymWriter_PdbWriter_Vtbl; This->ref = 1; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": SymWriter.lock");
Signed-off-by: Esme Povirk esme@codeweavers.com --- dlls/diasymreader/writer.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/dlls/diasymreader/writer.c b/dlls/diasymreader/writer.c index a675d79ccf9..3e5f43ddea5 100644 --- a/dlls/diasymreader/writer.c +++ b/dlls/diasymreader/writer.c @@ -17,6 +17,7 @@ */
#include <stdarg.h> +#include <time.h>
#define COBJMACROS
@@ -39,6 +40,7 @@ typedef struct SymWriter { LONG ref; CRITICAL_SECTION lock; GUID pdb_guid; + DWORD pdb_timestamp; DWORD pdb_age; WCHAR pdb_filename[MAX_PATH]; } SymWriter; @@ -240,6 +242,8 @@ static HRESULT WINAPI SymWriter_Initialize(ISymUnmanagedWriter5 *iface, IUnknown if (filename) wcsncpy_s(This->pdb_filename, MAX_PATH, filename, _TRUNCATE);
+ This->pdb_timestamp = _time32(NULL); + LeaveCriticalSection(&This->lock);
return S_OK; @@ -465,8 +469,20 @@ static HRESULT WINAPI SymWriter_GetPath(IPdbWriter *iface, DWORD ccData, DWORD *
static HRESULT WINAPI SymWriter_GetSignatureAge(IPdbWriter *iface, DWORD *timestamp, DWORD *age) { - FIXME("(%p,%p,%p)\n", iface, timestamp, age); - return E_NOTIMPL; + SymWriter *This = impl_from_IPdbWriter(iface); + + TRACE("(%p,%p,%p)\n", This, timestamp, age); + + EnterCriticalSection(&This->lock); + + if (timestamp) + *timestamp = This->pdb_timestamp; + if (age) + *age = This->pdb_age; + + LeaveCriticalSection(&This->lock); + + return S_OK; }
static const IPdbWriterVtbl SymWriter_PdbWriter_Vtbl = {
Signed-off-by: Esme Povirk esme@codeweavers.com --- dlls/diasymreader/writer.c | 58 +++++++++++++++++++------------------- 1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/dlls/diasymreader/writer.c b/dlls/diasymreader/writer.c index 3e5f43ddea5..0568a58264c 100644 --- a/dlls/diasymreader/writer.c +++ b/dlls/diasymreader/writer.c @@ -125,19 +125,19 @@ static HRESULT WINAPI SymWriter_DefineDocument(ISymUnmanagedWriter5 *iface, cons static HRESULT WINAPI SymWriter_SetUserEntryPoint(ISymUnmanagedWriter5 *iface, mdMethodDef entryMethod) { FIXME("(%p,0x%x)\n", iface, entryMethod); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_OpenMethod(ISymUnmanagedWriter5 *iface, mdMethodDef method) { FIXME("(%p,0x%x)\n", iface, method); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_CloseMethod(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_OpenScope(ISymUnmanagedWriter5 *iface, ULONG32 startOffset, @@ -150,14 +150,14 @@ static HRESULT WINAPI SymWriter_OpenScope(ISymUnmanagedWriter5 *iface, ULONG32 s static HRESULT WINAPI SymWriter_CloseScope(ISymUnmanagedWriter5 *iface, ULONG32 endOffset) { FIXME("(%p,%u)\n", iface, endOffset); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_SetScopeRange(ISymUnmanagedWriter5 *iface, ULONG32 scopeID, ULONG32 startOffset, ULONG32 endOffset) { FIXME("(%p,%u,%u,%u)\n", iface, scopeID, startOffset, endOffset); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineLocalVariable(ISymUnmanagedWriter5 *iface, const WCHAR *name, @@ -165,7 +165,7 @@ static HRESULT WINAPI SymWriter_DefineLocalVariable(ISymUnmanagedWriter5 *iface, ULONG32 addr1, ULONG32 addr2, ULONG32 addr3, ULONG32 startOffset, ULONG32 endOffset) { FIXME("(%p,%s,0x%x,%u,%u)\n", iface, debugstr_w(name), attributes, cSig, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineParameter(ISymUnmanagedWriter5 *iface, const WCHAR *name, @@ -173,7 +173,7 @@ static HRESULT WINAPI SymWriter_DefineParameter(ISymUnmanagedWriter5 *iface, con ULONG32 addr1, ULONG32 addr2, ULONG32 addr3) { FIXME("(%p,%s,0x%x,%u,%u)\n", iface, debugstr_w(name), attributes, sequence, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineField(ISymUnmanagedWriter5 *iface, mdTypeDef parent, @@ -181,7 +181,7 @@ static HRESULT WINAPI SymWriter_DefineField(ISymUnmanagedWriter5 *iface, mdTypeD ULONG32 addr1, ULONG32 addr2, ULONG32 addr3) { FIXME("(%p,0x%x,%s,0x%x,%u,%u)\n", iface, parent, debugstr_w(name), attributes, cSig, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineGlobalVariable(ISymUnmanagedWriter5 *iface, const WCHAR *name, @@ -189,45 +189,45 @@ static HRESULT WINAPI SymWriter_DefineGlobalVariable(ISymUnmanagedWriter5 *iface ULONG32 addr1, ULONG32 addr2, ULONG32 addr3) { FIXME("(%p,%s,0x%x,%u,%u)\n", iface, debugstr_w(name), attributes, cSig, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_Close(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_SetSymAttributes(ISymUnmanagedWriter5 *iface, mdToken parent, const WCHAR *name, ULONG32 cData, unsigned char data[]) { FIXME("(%p,0x%x,%s,%u)\n", iface, parent, debugstr_w(name), cData); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_OpenNamespace(ISymUnmanagedWriter5 *iface, const WCHAR *name) { FIXME("(%p,%s)\n", iface, debugstr_w(name)); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_CloseNamespace(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_UsingNamespace(ISymUnmanagedWriter5 *iface, const WCHAR *fullName) { FIXME("(%p,%s)\n", iface, debugstr_w(fullName)); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_SetMethodSourceRange(ISymUnmanagedWriter5 *iface, ISymUnmanagedDocumentWriter *startDoc, ULONG32 startLine, ULONG32 startColumn, ISymUnmanagedDocumentWriter *endDoc, ULONG32 endLine, ULONG32 endColumn) { FIXME("(%p,%p,%u,%u,%p,%u,%u)\n", iface, startDoc, startLine, startColumn, endDoc, endLine, endColumn); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_Initialize(ISymUnmanagedWriter5 *iface, IUnknown *emitter, const WCHAR *filename, @@ -297,33 +297,33 @@ static HRESULT WINAPI SymWriter_DefineSequencePoints(ISymUnmanagedWriter5 *iface ULONG32 spCount, ULONG32 offsets[], ULONG32 lines[], ULONG32 columns[], ULONG32 endLines[], ULONG32 endColumns[]) { FIXME("(%p,%p,%u)\n", iface, document, spCount); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_RemapToken(ISymUnmanagedWriter5 *iface, mdToken oldToken, mdToken newToken) { FIXME("(%p,0x%x,0x%x)\n", iface, oldToken, newToken); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_Initialize2(ISymUnmanagedWriter5 *iface, IUnknown *emitter, const WCHAR *tempFilename, IStream *pIStream, BOOL fFullBuild, const WCHAR *finalFilename) { FIXME("(%p,%p,%s,%p,%u,%s)\n", iface, emitter, debugstr_w(tempFilename), pIStream, fFullBuild, debugstr_w(finalFilename)); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineConstant(ISymUnmanagedWriter5 *iface, const WCHAR *name, VARIANT value, ULONG32 cSig, unsigned char signature[]) { FIXME("(%p,%s,%s,%u,%p)\n", iface, debugstr_w(name), debugstr_variant(&value), cSig, signature); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_Abort(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineLocalVariable2(ISymUnmanagedWriter5 *iface, const WCHAR *name, ULONG32 attributes, @@ -331,32 +331,32 @@ static HRESULT WINAPI SymWriter_DefineLocalVariable2(ISymUnmanagedWriter5 *iface ULONG32 startOffset, ULONG32 endOffset) { FIXME("(%p,%s,0x%x,0x%x,%u)\n", iface, debugstr_w(name), attributes, sigToken, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineGlobalVariable2(ISymUnmanagedWriter5 *iface, const WCHAR *name, ULONG32 attributes, mdSignature sigToken, ULONG32 addrKind, ULONG32 addr1, ULONG32 addr2, ULONG32 addr3) { FIXME("(%p,%s,0x%x,0x%x,%u)\n", iface, debugstr_w(name), attributes, sigToken, addrKind); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_DefineConstant2(ISymUnmanagedWriter5 *iface, const WCHAR *name, VARIANT value, mdSignature sigToken) { FIXME("(%p,%s,%s,0x%x)\n", iface, debugstr_w(name), debugstr_variant(&value), sigToken); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_OpenMethod2(ISymUnmanagedWriter5 *iface, mdMethodDef method, ULONG32 isect, ULONG32 offset) { FIXME("(%p,0x%x,%u,%u)\n", iface, method, isect, offset); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_Commit(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_GetDebugInfoWithPadding(ISymUnmanagedWriter5 *iface, IMAGE_DEBUG_DIRECTORY *pIDD, DWORD cbData, @@ -369,20 +369,20 @@ static HRESULT WINAPI SymWriter_GetDebugInfoWithPadding(ISymUnmanagedWriter5 *if static HRESULT WINAPI SymWriter_OpenMapTokensToSourceSpans(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_CloseMapTokensToSourceSpans(ISymUnmanagedWriter5 *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_MapTokenToSourceSpan(ISymUnmanagedWriter5 *iface, mdToken token, ISymUnmanagedDocumentWriter* document, ULONG32 line, ULONG32 column, ULONG32 endLine, ULONG32 endColumn) { FIXME("(%p,%x,%p,%u,%u,%u,%u)\n", iface, token, document, line, column, endLine, endColumn); - return E_NOTIMPL; + return S_OK; }
@@ -458,7 +458,7 @@ static HRESULT WINAPI SymWriter_OpenMod(IPdbWriter *iface, const WCHAR *modulena static HRESULT WINAPI SymWriter_CloseMod(IPdbWriter *iface) { FIXME("(%p)\n", iface); - return E_NOTIMPL; + return S_OK; }
static HRESULT WINAPI SymWriter_GetPath(IPdbWriter *iface, DWORD ccData, DWORD *pccData, WCHAR *path)
Signed-off-by: Esme Povirk esme@codeweavers.com --- dlls/diasymreader/writer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/diasymreader/writer.c b/dlls/diasymreader/writer.c index 0568a58264c..0c871073e01 100644 --- a/dlls/diasymreader/writer.c +++ b/dlls/diasymreader/writer.c @@ -144,7 +144,8 @@ static HRESULT WINAPI SymWriter_OpenScope(ISymUnmanagedWriter5 *iface, ULONG32 s ULONG32 *pRetVal) { FIXME("(%p,%u,%p)\n", iface, startOffset, pRetVal); - return E_NOTIMPL; + *pRetVal = 0xdeadbeef; + return S_OK; }
static HRESULT WINAPI SymWriter_CloseScope(ISymUnmanagedWriter5 *iface, ULONG32 endOffset)
-
Esme Povirk