Re: user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

[Paul Vriens]

On 01/11/2010 09:47 PM, Peter Dons Tychsen wrote:
> Try 3 of this patch:
> - Moved check to server.
> - Removed handling of error code translation after input from AJ.
>
> Thanks,
>
> /pedro

Hi Peter,

This patch has introduced test failures on NT4 and below (tested locally):

http://test.winehq.org/data/tests/user32:win.html

The callback is entered several times on NT4 (only once on XP) so it 
seems. The test crashes on Win98 btw.

Could you have a look?

You can use the winetestbot (https://winetestbot.geldorp.nl/) to check 
the failures on NT4. I can assist with Win9x testing if needed.

I'm busy setting up a local winetestbot that includes Win95, Win98 and 
WinMe.

user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

[Peter Dons Tychsen]

Hey Paul,

Thanks for cleaning up the crashing 9x test-case so fast.
> This patch has introduced test failures on NT4 and below (tested locally):
>
> http://test.winehq.org/data/tests/user32:win.html

Sorry for that.
> The callback is entered several times on NT4 (only once on XP) so it 
> seems. The test crashes on Win98 btw.

Even more sorry :-). I would seem that the test-case would do good with
a re-entry protection. Do you know where it crashes?
> You can use the winetestbot (https://winetestbot.geldorp.nl/) to check 
> the failures on NT4. I can assist with Win9x testing if needed.

I will check it out. Nice server!
> I'm busy setting up a local winetestbot that includes Win95, Win98 and 
> WinMe.

Great!

Thanks,

/pedro

user32: Do not allow a change of capture if the currently capture window is a menu unless explicitly specified (try3)

[Paul Vriens]

On 01/20/2010 02:39 AM, Peter Dons Tychsen wrote:
> Hey Paul,
>
> Thanks for cleaning up the crashing 9x test-case so fast.

Well it still crashes but at least it runs now on Win95.
> > This patch has introduced test failures on NT4 and below (tested locally):
> >
> > http://test.winehq.org/data/tests/user32:win.html
>
> Sorry for that.
> > The callback is entered several times on NT4 (only once on XP) so it
> > seems. The test crashes on Win98 btw.
>
> Even more sorry :-). I would seem that the test-case would do good with
> a re-entry protection. Do you know where it crashes?

Not exactly. Extra logging is difficult as the output seems not 
sequential. I assume though that it happened when either touching hWnd 
after it's destroyed or the destruction for the second time.

So "re-entry" could solve the crash but that still leaves us with loads 
of errors presumably (looking at NT4).
> > You can use the winetestbot (https://winetestbot.geldorp.nl/) to check
> > the failures on NT4. I can assist with Win9x testing if needed.
>
> I will check it out. Nice server!
> > I'm busy setting up a local winetestbot that includes Win95, Win98 and
> > WinMe.

Well, Ge has very recently added Win95 and Win98 to the mentioned 
winetestbot.