Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

[Nikolay Sivov]

On 2/26/2011 23:01, Gerald Pfeifer wrote:
> dlls/comctl32/tooltips.c |    7 +++----
>   1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c
> index a2e58e0..445845c 100644
> --- a/dlls/comctl32/tooltips.c
> +++ b/dlls/comctl32/tooltips.c
> @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW)
>
> static LRESULT
> -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit,
> -
>               BOOL isW)
>
> +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit)
>   {
>       TTTOOL_INFO *toolPtr;
>       INT nTool;
> @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
>
> case TTM_HITTESTA:
>    case TTM_HITTESTW:
> -
>    return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam,
> -
>                                  uMsg == TTM_HITTESTW);
> -
>    return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam);
> - case TTM_NEWTOOLRECTA:
>  case TTM_NEWTOOLRECTW:
>      return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam);

This should properly handle text instead of removing A/W case.

comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

[James McKenzie]

On 2/27/11 1:46 AM, Nikolay Sivov wrote:
> On 2/26/2011 23:01, Gerald Pfeifer wrote:
> > dlls/comctl32/tooltips.c |    7 +++----
> >   1 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c
> > index a2e58e0..445845c 100644
> > --- a/dlls/comctl32/tooltips.c
> > +++ b/dlls/comctl32/tooltips.c
> > @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO 
> > *infoPtr, TTTOOLINFOW *ti, BOOL isW)
> >
> > static LRESULT
> > -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW 
> > lptthit,
> > -
> >               BOOL isW)
> >
> > +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW 
> > lptthit)
> >   {
> >       TTTOOL_INFO *toolPtr;
> >       INT nTool;
> > @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, 
> > WPARAM wParam, LPARAM lParam)
> >   case TTM_HITTESTA:
> >   case TTM_HITTESTW:
> > -
> >    return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam,
> > -
> >                                  uMsg == TTM_HITTESTW);
> > -
> >    return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam);
> > -
> > case TTM_NEWTOOLRECTA:
> > case TTM_NEWTOOLRECTW:
> >     return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam);
>
> This should properly handle text instead of removing A/W case.

Even if all it does is convert ANSI to UNICODE and then call the UNICODE 
case correct?

This is more a question on how I should handle a case I'm working with 
for riched20, not a comment on this particular piece of code.

James McKenzie