Re: [PATCH 1/1] gameux/tests: verifying registry values created by GameExplorer (try 4)

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4793

Your paranoid android.

=== W7PRO (32 bit gameexplorer) ===
gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)

=== W7PROX64 (32 bit gameexplorer) ===
gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)

=== W7PROX64 (64 bit gameexplorer) ===
gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)

[PATCH 1/1] gameux/tests: verifying registry values created by GameExplorer (try 4)

[Mariusz Pluciński]

W dniu 26.08.2010 18:34,  (Marvin) pisze:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://testbot.winehq.org/JobDetails.pl?Key=4793
>
> Your paranoid android.
>
> === W7PRO (32 bit gameexplorer) ===
> gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
> gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)
>
> === W7PROX64 (32 bit gameexplorer) ===
> gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
> gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)
>
> === W7PROX64 (64 bit gameexplorer) ===
> gameexplorer.c:453: Test failed: failed while checking registry value (error 0x1)
> gameexplorer.c:471: Test failed: failed while checking registry value (error 0x1)

It seems that test bot did not rebuild the .gdf.xml file which I 
attached as resource (I don't see call of wrc in WINEBUILD log). I also 
notified similar behavior on my machine. It is because there's no rule 
in Makefile which depends on this file.

Could you tell me is there proper way to tell make to track changes in 
my custom file? Expected effect is running wrc while build if there was 
modification in my .gdf.xml file (currently, it is started only if .rc 
file was modified). Of course, Makefiles in Wine are auto-generated, so 
the solution would add code only to Makefile.in file.

[PATCH 1/1] gameux/tests: verifying registry values created by GameExplorer (try 4)

[Octavian Voicu]

2010/8/29 Mariusz Pluciński :
> Could you tell me is there proper way to tell make to track changes in my
> custom file? Expected effect is running wrc while build if there was
> modification in my .gdf.xml file (currently, it is started only if .rc file
> was modified). Of course, Makefiles in Wine are auto-generated, so the
> solution would add code only to Makefile.in file.

You need to add a @makedep directive in gameux/tests/rsrc.rc:

/* @makedep: test.gdf.xml */
ID_GDF_XML          DATA          "test.gdf.xml"

This should include test.gdf.xml as a dependency for rsrc.res in the
automatically generated Makefile. See dlls/cards/cards.rc for more
examples.

Octavian

[PATCH 1/1] gameux/tests: verifying registry values created by GameExplorer (try 4)

[Mariusz Pluciński]

W dniu 29.08.2010 18:33, Octavian Voicu pisze:
> 2010/8/29 Mariusz Pluciński:
> > Could you tell me is there proper way to tell make to track changes in my
> > custom file? Expected effect is running wrc while build if there was
> > modification in my .gdf.xml file (currently, it is started only if .rc file
> > was modified). Of course, Makefiles in Wine are auto-generated, so the
> > solution would add code only to Makefile.in file.
>
> You need to add a @makedep directive in gameux/tests/rsrc.rc:
>
> /* @makedep: test.gdf.xml */
> ID_GDF_XML          DATA          "test.gdf.xml"
>
> This should include test.gdf.xml as a dependency for rsrc.res in the
> automatically generated Makefile. See dlls/cards/cards.rc for more
> examples.
>
> Octavian

Thanks Octavian, it works exactly as I expected.