Re: [1/2] WineD3D: Mark GL Surface Clean after Fresh Surface Download

[Peter Oberndorfer]

On Wednesday 03 January 2007 02:48, Phil Costin wrote:
> This patch resets the SFLAG_GLDIRTY flag for a surface once the GL surface
> data has been refreshed in surface_download_data().
>
> Thanks to Stefan Dösinger for his advice in IRC during the implementation of
> these 2 patches.
> diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
> index 031d320..5cb9bf6 100644
> --- a/dlls/wined3d/surface.c
> +++ b/dlls/wined3d/surface.c
> @@ -142,6 +142,8 @@ static void surface_download_data(IWineD
>                  }
>              }
>          }
> +       /* No longer dirty */
> - This->Flags &= SFLAG_GLDIRTY;

I think there is a ~ missing here,
else everything but the dirty flag will be cleared.
> }
>  }

Greetings Peter

[1/2] WineD3D: Mark GL Surface Clean after Fresh Surface Download

[Phil Costin]

Peter Oberndorfer wrote:
> On Wednesday 03 January 2007 02:48, Phil Costin wrote:
> > This patch resets the SFLAG_GLDIRTY flag for a surface once the GL
> > surface data has been refreshed in surface_download_data().
> >
> > Thanks to Stefan Dösinger for his advice in IRC during the implementation
> > of these 2 patches.
> > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
> > index 031d320..5cb9bf6 100644
> > --- a/dlls/wined3d/surface.c
> > +++ b/dlls/wined3d/surface.c
> > @@ -142,6 +142,8 @@ static void surface_download_data(IWineD
> > }
> > }
> > }
> > +       /* No longer dirty */
> > - This->Flags &= SFLAG_GLDIRTY;
>
> I think there is a ~ missing here,
> else everything but the dirty flag will be cleared.
> > }
> > }
>
> Greetings Peter

Thanks Peter,

You are correct, it worked its way in there. It's taken from a larger patch
I'm working on and I didn't spot it immediately.

I will re-submit these patches (1 and 2) when I have ironed out a few
overall remaining issues I have.

Regards,
Phil