Re: [PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.

[Alexandre Julliard]

Huw Davies  writes:
> dlls/gdi32/tests/bitmap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

The is_win9x test is broken, that GetWindowLongPtrW call will return 0
on all platforms, so it breaks the tests on Wine:

gcc -m32 -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith  -g -O2 -Werror  -o bitmap.o bitmap.c
../../../tools/winegcc/winegcc -m32 -B../../../tools/winebuild -mconsole  bitmap.o brush.o clipping.o dc.o font.o gdiobj.o generated.o icm.o mapping.o metafile.o palette.o path.o pen.o    testlist.o  -o gdi32_test.exe.so ../../../libs/port/libwine_port.a -luser32 -lgdi32 -lkernel32   
../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so bitmap.c && touch bitmap.ok
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
bitmap.c:105: Test failed: win9x does not initialize the bitmap
make: *** [bitmap.ok] Error 10

[PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.

[Paul Vriens]

Alexandre Julliard wrote:
> Huw Davies  writes:
> > dlls/gdi32/tests/bitmap.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
>
> The is_win9x test is broken, that GetWindowLongPtrW call will return 0
> on all platforms, so it breaks the tests on Wine:

But that's also the same logic we are using in winetest (function 
running_on_visible_desktop). So that's broken too?

[PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.

[Alexandre Julliard]

Paul Vriens  writes:
> But that's also the same logic we are using in winetest (function
> running_on_visible_desktop). So that's broken too?

Yes, that's broken.