Executables icons

[BiGgUn]

Hi,

I wonder why icons located in an executable are not viewable in GetOpenFileName ? I had a look to the source code
(dlls/shell32/folder.c and dlls/shell32/classes.c) and saw that  a search is made in the registry. But this search failed because my
system.reg doesn't have the queried entry ( [Software\Classes\.exe]). I noticed that the winedefault.reg doesn't have the queried
entry also. When this search fails, a default icon is applied.

By manually adding this entry in system.reg, it is still not possible to get the executables icons :-\ I also saw that
[Software\Classes\.exe\DefaultIcon] is also queried. Even if i manually add this entry again, it's not successfull. I think i've
missed something in these entries definition but i don't know what. Anyway, by forcing the code to look inside executable for icons,
they finally appear :)

But it's better to find another solution. How registry should be setted up (system.reg / winedefault.reg) ? Do we need to review
the code (adding special case for exe files) ?

Stephan

P.S.:
   Excuse me if  i bother you with my questions.

[Martin Fuchs]

Hi,
> I wonder why icons located in an executable are not viewable in
> GetOpenFileName ? I had a look to the source code (dlls/shell32/folder.c
> and dlls/shell32/classes.c) and saw that  a search is made in the registry.
> But this search failed because my system.reg doesn't have the queried entry
> ( [Software\Classes\.exe]). I noticed that the winedefault.reg doesn't
> have the queried entry also. When this search fails, a default icon is
> applied.

I tried and imported the following entries in the registry:

[Software\Classes\.exe] 1055664996
@="exefile"

[Software\Classes\exefile\DefaultIcon] 1055665049
@="%1"

It does work!
it displays the exe-icons, when switching into detail mode of the 
GetOpenFile-dialog box.

--
Martin Fuchs
[e-mail]

[BiGgUn]

> I tried and imported the following entries in the registry:
> [Software\Classes\.exe] 1055664996
> @="exefile"
> [Software\Classes\exefile\DefaultIcon] 1055665049
> @="%1"

It works fine! Thanks

[Sylvain Petreolle]

Since this works here too,I sent a patch to wine-patches.
Changelog:
Display icons of executables in the OpenFile dialog boxes.

BiGgUn and Martin Fuchs for credits.
> I tried and imported the following entries in the registry:
>
> [Software\Classes\.exe] 1055664996
> @="exefile"
>
> [Software\Classes\exefile\DefaultIcon] 1055665049
> @="%1"
>
> It does work!
> it displays the exe-icons, when switching into detail mode of the 
> GetOpenFile-dialog box.
>
> --
> Martin Fuchs
> [e-mail]

=====
Sylvain Petreolle (spetreolle at users dot sourceforge dot net) 
ICQ #170597259

"What if tomorrow the War could be over ?" Morpheus, in "Reloaded".

For the Law of Oil and Fire, Im an European that lives in France.
For all my Brothers and friends, Im a human living on Earth.

___________________________________________________________
Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français !
Yahoo! Mail : http://fr.mail.yahoo.com

[BiGgUn]

> Since this works here too,I sent a patch to wine-patches.
> Changelog:
> Display icons of executables in the OpenFile dialog boxes.

Maybe not only OpenFile dialog boxes will be affected.
> BiGgUn and Martin Fuchs for credits.
> > I tried and imported the following entries in the registry:
> >
> > [Software\Classes\.exe] 1055664996
> > @="exefile"
> >
> > [Software\Classes\exefile\DefaultIcon] 1055665049
> > @="%1"

But the last problem is for executables without icons inside of them. The wrong default icon is applied.