Re: [PATCH v2 1/2] explorer: Improve tray sizing and style.

[Alexandre Julliard]

Zebediah Figura  writes:
> v2: use appropriate system metrics.
> Signed-off-by: Zebediah Figura
>
> programs/explorer/systray.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)

It's mainly a matter of taste, but this doesn't look better to me. In
particular having buttons remain pushed when active feels wrong.

[PATCH v2 1/2] explorer: Improve tray sizing and style.

[Zebediah Figura]

On 07/13/2017 02:04 AM, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > v2: use appropriate system metrics.
> > Signed-off-by: Zebediah Figura
> >
> > programs/explorer/systray.c | 20 +++++++++++---------
> >   1 file changed, 11 insertions(+), 9 deletions(-)
>
> It's mainly a matter of taste, but this doesn't look better to me. In
> particular having buttons remain pushed when active feels wrong.

It's how Windows has it (at least on XP upwards), but this patch is 
purely visual, so it can be dropped.