Is this a bug?

[Ian Pilcher]

While poking around in gdi.h, I came upon the following:

static inline INT WINE_UNUSED INTERNAL_XWSTODS(DC *dc, INT width)
{
    FLOAT floatWidth;

/* Perform operation with floating point */
    floatWidth = (FLOAT)width;
    INTERNAL_XWSTODS_FLOAT(dc, &floatWidth);

/* Round to integers */
    return GDI_ROUND(floatWidth);
}

... and a little later ...

static inline INT WINE_UNUSED INTERNAL_YWSTODS(DC *dc, INT height)
{
    FLOAT floatHeight;

/* Perform operation with floating point */
    floatHeight = (FLOAT)height;
    INTERNAL_XWSTODS_FLOAT(dc, &floatHeight);

/* Round to integers */
    return GDI_ROUND(floatHeight);
}

Shouldn't one of these (probably INTERNAL_YWSTODS) be calling
INTERNAL_YWSTODS_FLOAT instead of INTERNAL_XWSTODS_FLOAT?

[Huw D M Davies]

On Tue, Jun 05, 2001 at 06:12:27PM -0500, Ian Pilcher wrote:
> While poking around in gdi.h, I came upon the following:
>
> static inline INT WINE_UNUSED INTERNAL_YWSTODS(DC *dc, INT height)
> {
>     FLOAT floatHeight;
> /* Perform operation with floating point */
> floatHeight = (FLOAT)height;
> INTERNAL_XWSTODS_FLOAT(dc, &floatHeight);
>
> /* Round to integers */
> return GDI_ROUND(floatHeight);
>
> }
>
> Shouldn't one of these (probably INTERNAL_YWSTODS) be calling
> INTERNAL_YWSTODS_FLOAT instead of INTERNAL_XWSTODS_FLOAT?

Yes, well spotted.  This one should indeed be calling
INTERNAL_YWSTODS_FLOAT  [This stuff is a mess anyway, but that's a
different sotry...].

Huw.