Re: Change threading defaults on FreeBSD

[Alexandre Julliard]

Gerald Pfeifer  writes:
> ChangeLog:
> On FreeBSD, build wine-pthread in addition to wine-kthread and make
> the former the default.

If you build both, then you need a way to decide which one will be
used. That's not the sort of detail we want to have users worry
about.

Change threading defaults on FreeBSD

[Gerald Pfeifer]

On Fri, 14 Apr 2006, Alexandre Julliard wrote:
> > On FreeBSD, build wine-pthread in addition to wine-kthread and make
> > the former the default.
>
> If you build both, then you need a way to decide which one will be
> used. That's not the sort of detail we want to have users worry
> about.

Well, but isn't this what my patch does? ;-)  By virtue of

freebsd*)
        AC_SUBST(MAIN_BINARY,"wine-pthread")
        AC_SUBST(EXTRA_BINARIES,"wine-kthread")

we build both wine-pthread and wine-kthread, and the former is installed 
as $PREFIX/bin/wine; wine-kthread just is an additional binary.

freebsd*)
        MAIN_BINARY="wine-pthread"
        EXTRA_BINARIES="wine-kthread"

Contrast this with the settings on Linux

linux* | k*bsd*-gnu)
        AC_SUBST(MAIN_BINARY,"wine-glibc")
        AC_SUBST(EXTRA_BINARIES,"wine-kthread wine-pthread wine-preloader") ;;

where we build wine-glibc (to be installed as $PREFIX/bin/wine) and in
addition both wine-kthread and wine-pthread, and install all of these.

At least this is my understanding of MAIN_BINARY versus EXTRA_BINARIES
and checks on how Wine installs on Linux and FreeBSD (with, and without
my patch).  Did I miss (or misunderstand) something?

Gerald

Change threading defaults on FreeBSD

[Alexandre Julliard]

Gerald Pfeifer  writes:
> Contrast this with the settings on Linux
>   linux* | k*bsd*-gnu)
>     AC_SUBST(MAIN_BINARY,"wine-glibc")
>     AC_SUBST(EXTRA_BINARIES,"wine-kthread wine-pthread wine-preloader") ;;
>
> where we build wine-glibc (to be installed as $PREFIX/bin/wine) and in
> addition both wine-kthread and wine-pthread, and install all of these.
>
> At least this is my understanding of MAIN_BINARY versus EXTRA_BINARIES
> and checks on how Wine installs on Linux and FreeBSD (with, and without
> my patch).  Did I miss (or misunderstand) something?

On Linux, wine-glibc (installed as wine) will detect the threading
flavor, and then exec wine-pthread or wine-kthread. You need to do
something like that too, otherwise it doesn't make sense to build
both, since users will always invoke the one installed as wine.