Re: [PATCH] msvcrt: change __libm_sse2_... functions internal names (exported names preserved) msvcr80, msvcr90, msvcr100, msvcr110, msvcr120: update spec file

[Piotr Caban]

On 12/22/15 10:54, Paul Gofman wrote:
> -void __cdecl __libm_sse2_acos(void)
> +void __cdecl l__libm_sse2_acos(void)

In other places where we need to rename functions "MSVCRT_" prefix is 
added to function name. Could you please change the function names this way?

Also it will be nicer to change the commit message to something like:
msvcrt: Rename __libm_sse2_* functions to fix compilation when using 
Intel compiler.

Thanks,
Piotr

[PATCH] msvcrt: change __libm_sse2_... functions internal names (exported names preserved) msvcr80, msvcr90, msvcr100, msvcr110, msvcr120: update spec file

[Paul Gofman]

done

On 12/22/2015 01:02 PM, Piotr Caban wrote:
> On 12/22/15 10:54, Paul Gofman wrote:
> > -void __cdecl __libm_sse2_acos(void)
> > +void __cdecl l__libm_sse2_acos(void)
>
> In other places where we need to rename functions "MSVCRT_" prefix is
> added to function name. Could you please change the function names
> this way?
>
> Also it will be nicer to change the commit message to something like:
> msvcrt: Rename __libm_sse2_* functions to fix compilation when using
> Intel compiler.
>
> Thanks,
> Piotr