Re: [resend 3/5] ddraw7/tests: test SetColorKey on cubemap surfaces

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-11-04 um 19:51 schrieb Riccardo Bortolato:
> - hr = IDirectDrawSurface7_GetColorKey(mipmap, DDCKEY_SRCBLT,
>
> &color_key); +    ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr
> %#x.\n", hr); +    color_key.dwColorSpaceLowValue = 0x0000ff00; +
> color_key.dwColorSpaceHighValue = 0x0000ff00; +    hr =
> IDirectDrawSurface7_SetColorKey(mipmap, DDCKEY_SRCBLT,
> &color_key); +    ok(SUCCEEDED(hr), "Failed to set color key, hr
> %#x.\n", hr);

One more thing that's interesting to test here: Set a different color
key, and after the successful SetColorKey test which one you get back.
You might even get DDERR_NOCOLORKEY back after the successful Set.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWO0wKAAoJEN0/YqbEcdMwsn4P/A9Mgwuq+4H0/2atLKdVlX7u
RBAx/ZrhNEXT5W0Kzo1eZCUD5RjKf4mnuUi6x6LwX7JczJ9Dxxcz2Xx4gfeb3Wmy
d6F2ttzejkKwG+tPkWfzc9AG0oZ0uFxvMuyBEdMqNxRAQXec7sxse9ELlsA7A1Wk
snwvheVQ7o6XP6qya9mJBgiyWRH/86VzhW4/P6EluINmcXCVL/UaZKnj7BgYL7Yy
pFvFN9r7N92bAspIsIl0MxnmxZ6qbK13qbqr4JJPvjSX8TfKQfoXsHj5BW0ZoZaR
uWBvKtTmF0mhcY3rVOr/tQcBtp7xBYB0QiqBwMx0lBS1gZyaoeasEEFcP8s4HROs
YHV3WKxG/esYAsqNfVRH+5wWUthTT0bthOv7mUuBwMC53kQOw5eqw9v5WOwW1Omu
HRZ6ssDfvMx9YWhw06DIPnaCfyEL2KfxksRHA6TMHWbY8lHNL5nP0cc+tQhKXymc
c2QS0awqTX95kjf+K0giBGRhnI/BXJa3jH2Bs9/8YXtyWq8k5UvKOZbjk6IUeeod
KVgARsBCQ+3idRRU9nGA4P0OkjRymQFS7U+2DLYofIjv71p/TldvkOPUKKG3y8N4
rMhpCgsyGxEuHKnz4eLTirrjGEp+NPNIy6R7aSqd/j5XjSaHujtZjv84UBuyF60Y
Z/UQmUCIFyr8IiIQSFZv
=Ktln
-----END PGP SIGNATURE-----

[resend 3/5] ddraw7/tests: test SetColorKey on cubemap surfaces

[Riccardo Bortolato]

Hey Stefan,

I don't have a Windows box so this is really difficult for me, is this
strictly necessary?

Ciao,
Riccardo

2015-11-05 13:31 GMT+01:00 Stefan Dösinger :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2015-11-04 um 19:51 schrieb Riccardo Bortolato:
> > - hr = IDirectDrawSurface7_GetColorKey(mipmap, DDCKEY_SRCBLT,
> >
> > &color_key); +    ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr
> > %#x.\n", hr); +    color_key.dwColorSpaceLowValue = 0x0000ff00; +
> > color_key.dwColorSpaceHighValue = 0x0000ff00; +    hr =
> > IDirectDrawSurface7_SetColorKey(mipmap, DDCKEY_SRCBLT,
> > &color_key); +    ok(SUCCEEDED(hr), "Failed to set color key, hr
> > %#x.\n", hr);
>
> One more thing that's interesting to test here: Set a different color
> key, and after the successful SetColorKey test which one you get back.
> You might even get DDERR_NOCOLORKEY back after the successful Set.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWO0wKAAoJEN0/YqbEcdMwsn4P/A9Mgwuq+4H0/2atLKdVlX7u
> RBAx/ZrhNEXT5W0Kzo1eZCUD5RjKf4mnuUi6x6LwX7JczJ9Dxxcz2Xx4gfeb3Wmy
> d6F2ttzejkKwG+tPkWfzc9AG0oZ0uFxvMuyBEdMqNxRAQXec7sxse9ELlsA7A1Wk
> snwvheVQ7o6XP6qya9mJBgiyWRH/86VzhW4/P6EluINmcXCVL/UaZKnj7BgYL7Yy
> pFvFN9r7N92bAspIsIl0MxnmxZ6qbK13qbqr4JJPvjSX8TfKQfoXsHj5BW0ZoZaR
> uWBvKtTmF0mhcY3rVOr/tQcBtp7xBYB0QiqBwMx0lBS1gZyaoeasEEFcP8s4HROs
> YHV3WKxG/esYAsqNfVRH+5wWUthTT0bthOv7mUuBwMC53kQOw5eqw9v5WOwW1Omu
> HRZ6ssDfvMx9YWhw06DIPnaCfyEL2KfxksRHA6TMHWbY8lHNL5nP0cc+tQhKXymc
> c2QS0awqTX95kjf+K0giBGRhnI/BXJa3jH2Bs9/8YXtyWq8k5UvKOZbjk6IUeeod
> KVgARsBCQ+3idRRU9nGA4P0OkjRymQFS7U+2DLYofIjv71p/TldvkOPUKKG3y8N4
> rMhpCgsyGxEuHKnz4eLTirrjGEp+NPNIy6R7aSqd/j5XjSaHujtZjv84UBuyF60Y
> Z/UQmUCIFyr8IiIQSFZv
> =Ktln
> -----END PGP SIGNATURE-----

[resend 3/5] ddraw7/tests: test SetColorKey on cubemap surfaces

[Stefan Dösinger]

> Am 05.11.2015 um 15:21 schrieb Riccardo Bortolato :
>
> Hey Stefan,
>
> I don't have a Windows box so this is really difficult for me, is this
> strictly necessary?

I can extend the test when I'm back from the mentor summit, no problem for me.

Sooner or later you do want a Windows box for testing though :-)
> Ciao,
> Riccardo
>
> 2015-11-05 13:31 GMT+01:00 Stefan Dösinger :
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > Am 2015-11-04 um 19:51 schrieb Riccardo Bortolato:
> > > - hr = IDirectDrawSurface7_GetColorKey(mipmap, DDCKEY_SRCBLT,
> > >
> > > &color_key); +    ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr
> > > %#x.\n", hr); +    color_key.dwColorSpaceLowValue = 0x0000ff00; +
> > > color_key.dwColorSpaceHighValue = 0x0000ff00; +    hr =
> > > IDirectDrawSurface7_SetColorKey(mipmap, DDCKEY_SRCBLT,
> > > &color_key); +    ok(SUCCEEDED(hr), "Failed to set color key, hr
> > > %#x.\n", hr);
> >
> > One more thing that's interesting to test here: Set a different color
> > key, and after the successful SetColorKey test which one you get back.
> > You might even get DDERR_NOCOLORKEY back after the successful Set.
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
> >
> > iQIcBAEBCAAGBQJWO0wKAAoJEN0/YqbEcdMwsn4P/A9Mgwuq+4H0/2atLKdVlX7u
> > RBAx/ZrhNEXT5W0Kzo1eZCUD5RjKf4mnuUi6x6LwX7JczJ9Dxxcz2Xx4gfeb3Wmy
> > d6F2ttzejkKwG+tPkWfzc9AG0oZ0uFxvMuyBEdMqNxRAQXec7sxse9ELlsA7A1Wk
> > snwvheVQ7o6XP6qya9mJBgiyWRH/86VzhW4/P6EluINmcXCVL/UaZKnj7BgYL7Yy
> > pFvFN9r7N92bAspIsIl0MxnmxZ6qbK13qbqr4JJPvjSX8TfKQfoXsHj5BW0ZoZaR
> > uWBvKtTmF0mhcY3rVOr/tQcBtp7xBYB0QiqBwMx0lBS1gZyaoeasEEFcP8s4HROs
> > YHV3WKxG/esYAsqNfVRH+5wWUthTT0bthOv7mUuBwMC53kQOw5eqw9v5WOwW1Omu
> > HRZ6ssDfvMx9YWhw06DIPnaCfyEL2KfxksRHA6TMHWbY8lHNL5nP0cc+tQhKXymc
> > c2QS0awqTX95kjf+K0giBGRhnI/BXJa3jH2Bs9/8YXtyWq8k5UvKOZbjk6IUeeod
> > KVgARsBCQ+3idRRU9nGA4P0OkjRymQFS7U+2DLYofIjv71p/TldvkOPUKKG3y8N4
> > rMhpCgsyGxEuHKnz4eLTirrjGEp+NPNIy6R7aSqd/j5XjSaHujtZjv84UBuyF60Y
> > Z/UQmUCIFyr8IiIQSFZv
> > =Ktln
> > -----END PGP SIGNATURE-----